Commit 787681f
committed
Update tests, workflows, and documentation for parameter order fix
This commit includes follow-up changes after fixing buildConsoleReplay parameter order:
1. **Update test files for new parameter order**:
- packages/react-on-rails/tests/buildConsoleReplay.test.js
- Updated all test calls to use new signature: (numberOfMessagesToSkip, consoleHistory, nonce)
2. **Sanitize test fixtures**:
- packages/react-on-rails-pro-node-renderer/tests/fixtures/
- Replaced real personal info with generic test data
- Changed user IDs, emails, names, addresses to test values
3. **Fix Pro package CI workflows**:
- .github/workflows/pro-lint.yml: Build only Pro package instead of all
- .github/workflows/pro-test-package-and-gem.yml: Fix yarn.lock cache path
4. **Update migration analysis docs**:
- .claude/docs/analysis/INDEX.md
- .claude/docs/analysis/MONOREPO_MIGRATION_ANALYSIS.md
- Mark Phase 5 as complete, update status and timeline
All changes verified locally.1 parent 851d5ee commit 787681f
File tree
6 files changed
+58
-42
lines changed- .claude/docs/analysis
- .github/workflows
- packages
- react-on-rails-pro-node-renderer/tests/fixtures/projects/friendsandguests/1a7fe417
- react-on-rails/tests
6 files changed
+58
-42
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
| 103 | + | |
| 104 | + | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
183 | 191 | | |
184 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
185 | 195 | | |
186 | | - | |
187 | | - | |
188 | | - | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
189 | 203 | | |
190 | | - | |
| 204 | + | |
191 | 205 | | |
192 | | - | |
193 | | - | |
194 | | - | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
195 | 209 | | |
196 | | - | |
| 210 | + | |
197 | 211 | | |
198 | | - | |
199 | | - | |
200 | 212 | | |
| 213 | + | |
| 214 | + | |
201 | 215 | | |
202 | 216 | | |
203 | 217 | | |
204 | | - | |
205 | | - | |
| 218 | + | |
| 219 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | | - | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
215 | 217 | | |
216 | 218 | | |
217 | 219 | | |
218 | | - | |
| 220 | + | |
219 | 221 | | |
220 | 222 | | |
221 | 223 | | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
227 | 229 | | |
228 | 230 | | |
229 | 231 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
| 205 | + | |
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
| |||
0 commit comments