Skip to content

Commit 7bc0302

Browse files
justin808claude
andcommitted
Address PR feedback on README
- Fixed ASCII box borders to be straight - Changed "When You Need Pro" to bulleted list format - Changed "Node Renderer Pool" to "Proper Node Renderer" in comparison table - Fixed cached_react_component examples to use block syntax (not props: ->) - Updated FAQ: developers in an org can share the same license - Added "Early hydration" to Pro features list - Updated Node Renderer FAQ: "optional but recommended" - Clarified ExecJS is for "apps that do not require advanced performance features" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent d0755fd commit 7bc0302

File tree

1 file changed

+26
-21
lines changed

1 file changed

+26
-21
lines changed

react_on_rails_pro/README.md

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,18 @@ React on Rails Pro is a **commercial extension** to the open-source [React on Ra
4141

4242
```
4343
┌─────────────────────────────────────────────────┐
44-
│ React on Rails Pro (this package) │
44+
│ React on Rails Pro (this package)
4545
│ • SSR performance enhancements │
4646
│ • React Server Components │
47-
│ • Advanced caching
48-
│ • Node.js rendering pool
47+
│ • Advanced caching │
48+
│ • Node.js rendering pool │
4949
└─────────────────────────────────────────────────┘
5050
5151
┌─────────────────────────────────────────────────┐
52-
│ React on Rails (open-source, required) │
53-
│ • Basic SSR
54-
│ • Component registration
55-
│ • Rails integration
52+
│ React on Rails (open-source, required)
53+
│ • Basic SSR │
54+
│ • Component registration │
55+
│ • Rails integration │
5656
└─────────────────────────────────────────────────┘
5757
```
5858

@@ -112,13 +112,13 @@ React on Rails Pro delivers **measurable performance improvements** for producti
112112

113113
Consider React on Rails Pro if you:
114114

115-
✅ Need **faster server-side rendering** for SEO and initial page loads
116-
✅ Want **advanced caching** to reduce server load
117-
✅ Require **React Server Components** (RSC) support
118-
✅ Need **streaming SSR** for progressive rendering
119-
✅ Want **code splitting** with React Router or loadable-components
120-
✅ Have **high-traffic applications** where performance matters
121-
✅ Need **professional support** for your Rails + React stack
115+
- ✅ Need **faster server-side rendering** for SEO and initial page loads
116+
- ✅ Want **advanced caching** to reduce server load
117+
- ✅ Require **React Server Components** (RSC) support
118+
- ✅ Need **streaming SSR** for progressive rendering
119+
- ✅ Want **code splitting** with React Router or loadable-components
120+
- ✅ Have **high-traffic applications** where performance matters
121+
- ✅ Need **professional support** for your Rails + React stack
122122

123123
### Pro vs. Open Source
124124

@@ -129,7 +129,7 @@ Consider React on Rails Pro if you:
129129
| Rails Integration |||
130130
| Fragment Caching |||
131131
| Prerender Caching |||
132-
| Node Renderer Pool |||
132+
| Proper Node Renderer |||
133133
| React Server Components |||
134134
| Streaming SSR |||
135135
| Code Splitting (SSR) |||
@@ -146,10 +146,14 @@ Cache React components at the Rails view layer with intelligent cache key genera
146146

147147
```ruby
148148
# Cache component output with automatic cache key from props
149-
<%= cached_react_component("UserProfile", props: { user_id: @user.id }) %>
149+
<%= cached_react_component("UserProfile", cache_key: [@user]) do
150+
{ user_id: @user.id }
151+
end %>
150152
151153
# Lazy evaluation of props - only evaluated on cache miss
152-
<%= cached_react_component("ExpensiveComponent", props: -> { expensive_calculation }) %>
154+
<%= cached_react_component("ExpensiveComponent", cache_key: [@user, @post]) do
155+
expensive_calculation
156+
end %>
153157
```
154158

155159
**Benefits:**
@@ -466,7 +470,7 @@ A: Yes, but it's FREE! Register at [shakacode.com/react-on-rails-pro](https://sh
466470

467471
**Q: Can multiple developers share one license?**
468472

469-
A: Each developer should get their own FREE license for development. For CI/CD, you can share one license via environment variable. [See team setup →](./LICENSE_SETUP.md#team-setup)
473+
A: Yes! All developers in an organization can share the same license. You can use a shared license via environment variable or configuration file. [See team setup →](./LICENSE_SETUP.md#team-setup)
470474

471475
**Q: What happens when my free license expires?**
472476

@@ -487,22 +491,23 @@ A: Pricing is customized based on your needs. Contact [[email protected]](mai
487491
A: Pro adds performance features on top of the open-source gem:
488492

489493
- Advanced caching (fragment + prerender)
490-
- Node.js rendering pool
494+
- Proper Node.js rendering pool
491495
- React Server Components
492496
- Streaming SSR
497+
- Early hydration
493498
- Code splitting with SSR support
494499

495500
[See full comparison →](#pro-vs-open-source)
496501

497502
**Q: Do I need the Node Renderer?**
498503

499-
A: No, it's optional. The Node Renderer provides the best performance for high-traffic sites and is required for:
504+
A: No, it's optional but recommended. The Node Renderer provides the best performance for high-traffic sites and is required for:
500505

501506
- Loadable-components with SSR
502507
- React Server Components
503508
- Streaming SSR
504509

505-
For simpler apps, ExecJS (the default) works fine.
510+
For apps that do not require advanced performance features, ExecJS (the default) works fine.
506511

507512
**Q: Is React on Rails Pro compatible with my React version?**
508513

0 commit comments

Comments
 (0)