Refactor CI packer version environment variable handling in workflows

Author: AbanoubGhadban

.github/workflows/examples.yml

@@ -97,7 +97,7 @@ jobs:
         run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
       - name: Set packer version environment variable
         run: |
-          echo "CI_PACKER_VERSION=${{ matrix.versions == 'oldest' && 'old' || 'new' }}" >> $GITHUB_ENV
+          echo "CI_PACKER_VERSION=${{ matrix.versions }}" >> $GITHUB_ENV
       - name: Main CI
         if: steps.changed-files.outputs.any_changed == 'true'
         run: bundle exec rake run_rspec:${{ matrix.versions == 'oldest' && 'web' || 'shaka' }}packer_examples

.github/workflows/main.yml

@@ -192,7 +192,7 @@ jobs:
       - run: cd spec/dummy && bundle info shakapacker
       - name: Set packer version environment variable
         run: |
-          echo "CI_PACKER_VERSION=${{ matrix.versions == 'oldest' && 'old' || 'new' }}" >> $GITHUB_ENV
+          echo "CI_PACKER_VERSION=${{ matrix.versions }}" >> $GITHUB_ENV
       - name: Main CI
         run: bundle exec rake run_rspec:all_dummy
       - name: Store test results

.github/workflows/rspec-package-specs.yml

@@ -49,7 +49,7 @@ jobs:
           git commit -am "stop generators from complaining about uncommitted code"
       - name: Set packer version environment variable
         run: |
-          echo "CI_PACKER_VERSION=${{ matrix.versions == 'oldest' && 'old' || 'new' }}" >> $GITHUB_ENV
+          echo "CI_PACKER_VERSION=${{ matrix.versions }}" >> $GITHUB_ENV
       - name: Run rspec tests
         run: bundle exec rspec spec/react_on_rails
       - name: Store test results

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb

@@ -51,7 +51,7 @@ class PlainReactOnRailsHelper
       allow(helper).to receive(:append_stylesheet_pack_tag)
       expect { helper.load_pack_for_generated_component("component_name", render_options) }.not_to raise_error
 
-      if ENV["CI_PACKER_VERSION"] == "old"
+      if ENV["CI_PACKER_VERSION"] == "oldest"
         expect(helper).to have_received(:append_javascript_pack_tag).with("generated/component_name", { defer: false })
       else
         expect(helper).to have_received(:append_javascript_pack_tag)

spec/react_on_rails/utils_spec.rb

@@ -10,9 +10,9 @@ module ReactOnRails
     # If rspec tests are run locally, we want to test both packers.
     # If rspec tests are run in CI, we want to test the packer specified in the CI_PACKER_VERSION environment variable.
     # Check script/convert and .github/workflows/rspec-package-specs.yml for more details.
-    packers_to_test = if ENV["CI_PACKER_VERSION"] == "old"
+    packers_to_test = if ENV["CI_PACKER_VERSION"] == "oldest"
                         ["webpacker"]
-                      elsif ENV["CI_PACKER_VERSION"] == "new"
+                      elsif ENV["CI_PACKER_VERSION"] == "newest"
                         ["shakapacker"]
                       else
                         %w[shakapacker webpacker]