Skip to content

Commit 8520d4e

Browse files
refactor: remove renderRequestId from script tags in ReactOnRailsHelper specs for improved clarity
1 parent 441c901 commit 8520d4e

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ class PlainReactOnRailsHelper
2121
{ "HTTP_ACCEPT_LANGUAGE" => "en" }
2222
)
2323
}
24-
25-
allow(ReactOnRails::ReactComponent::RenderOptions).to receive(:generate_request_id).and_return("123")
2624
end
2725

2826
let(:hash) do
@@ -197,7 +195,7 @@ def helper.append_javascript_pack_tag(name, **options)
197195
<script type="application/json" class="js-react-on-rails-component" \
198196
id="js-react-on-rails-component-App-react-component" \
199197
data-component-name="App" data-dom-id="App-react-component"
200-
data-force-load="true" data-render-request-id="123">{"name":"My Test Name"}</script>
198+
data-force-load="true">{"name":"My Test Name"}</script>
201199
SCRIPT
202200
end
203201

@@ -206,7 +204,7 @@ def helper.append_javascript_pack_tag(name, **options)
206204
<script type="application/json" class="js-react-on-rails-component" \
207205
id="js-react-on-rails-component-App-react-component" \
208206
data-component-name="App" data-dom-id="App-react-component"
209-
data-force-load="true" data-render-request-id="123">{}</script>
207+
data-force-load="true">{}</script>
210208
SCRIPT
211209
end
212210

@@ -255,7 +253,7 @@ def helper.append_javascript_pack_tag(name, **options)
255253
<script type="application/json" class="js-react-on-rails-component" \
256254
id="js-react-on-rails-component-App-react-component" \
257255
data-component-name="App" data-dom-id="App-react-component"
258-
data-force-load="true" data-render-request-id="123">{"name":"My Test Name"}</script>
256+
data-force-load="true">{"name":"My Test Name"}</script>
259257
SCRIPT
260258
end
261259

@@ -271,7 +269,7 @@ def helper.append_javascript_pack_tag(name, **options)
271269
<script type="application/json" class="js-react-on-rails-component" \
272270
id="js-react-on-rails-component-App-react-component-0" \
273271
data-component-name="App" data-dom-id="App-react-component-0"
274-
data-force-load="true" data-render-request-id="123">{"name":"My Test Name"}</script>
272+
data-force-load="true">{"name":"My Test Name"}</script>
275273
SCRIPT
276274
end
277275

@@ -293,7 +291,7 @@ def helper.append_javascript_pack_tag(name, **options)
293291
<script type="application/json" class="js-react-on-rails-component" \
294292
id="js-react-on-rails-component-App-react-component" \
295293
data-component-name="App" data-dom-id="App-react-component"
296-
data-force-load="true" data-render-request-id="123">{"name":"My Test Name"}</script>
294+
data-force-load="true">{"name":"My Test Name"}</script>
297295
SCRIPT
298296
end
299297

@@ -311,7 +309,7 @@ def helper.append_javascript_pack_tag(name, **options)
311309
<script type="application/json" class="js-react-on-rails-component" \
312310
id="js-react-on-rails-component-shaka_div" \
313311
data-component-name="App" data-dom-id="shaka_div"
314-
data-force-load="true" data-render-request-id="123">{"name":"My Test Name"}</script>
312+
data-force-load="true">{"name":"My Test Name"}</script>
315313
SCRIPT
316314
end
317315

0 commit comments

Comments
 (0)