Fix TypeScript generator tests and lint issues

- Fix RuboCop guard clause violation in install_generator.rb
- Add missing create_typescript_config method call for --typescript flag
- Fix indentation and syntax issues from RuboCop auto-correct
- Change TypeScript Redux template to use interface instead of type alias
  to match test expectations

All generator tests now pass and lint is clean.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/install_generator.rb

@@ -69,6 +69,7 @@ def invoke_generators
         if options.typescript?
           install_typescript_dependencies
           create_css_module_types
+          create_typescript_config
         end
         invoke "react_on_rails:base", [], { typescript: options.typescript? }
         if options.redux?
@@ -330,80 +331,80 @@ def install_typescript_dependencies
 
         # Fallback to npm if GeneratorHelper fails
         success = run "npm install --save-dev #{typescript_packages.join(' ')}"
-        unless success
-          warning = <<~MSG.strip
-            ⚠️  Failed to install TypeScript dependencies automatically.
-
-            Please run manually:
-                npm install --save-dev #{typescript_packages.join(' ')}
-          MSG
-          GeneratorMessages.add_warning(warning)
-        end
-      end
+        return if success
 
-      def create_css_module_types
-        puts Rainbow("📝 Creating CSS module type definitions...").yellow
+        warning = <<~MSG.strip
+          ⚠️  Failed to install TypeScript dependencies automatically.
 
-        # Ensure the types directory exists
-        FileUtils.mkdir_p("app/javascript/types")
+          Please run manually:
+              npm install --save-dev #{typescript_packages.join(' ')}
+        MSG
+        GeneratorMessages.add_warning(warning)
+      end
+    end
 
-        css_module_types_content = <<~TS.strip
-          // TypeScript definitions for CSS modules
-          declare module "*.module.css" {
-            const classes: { [key: string]: string };
-            export default classes;
-          }
+    def create_css_module_types
+      puts Rainbow("📝 Creating CSS module type definitions...").yellow
 
-          declare module "*.module.scss" {
-            const classes: { [key: string]: string };
-            export default classes;
-          }
+      # Ensure the types directory exists
+      FileUtils.mkdir_p("app/javascript/types")
 
-          declare module "*.module.sass" {
-            const classes: { [key: string]: string };
-            export default classes;
-          }
-        TS
+      css_module_types_content = <<~TS.strip
+        // TypeScript definitions for CSS modules
+        declare module "*.module.css" {
+          const classes: { [key: string]: string };
+          export default classes;
+        }
 
-        File.write("app/javascript/types/css-modules.d.ts", css_module_types_content)
-        puts Rainbow("✅ Created CSS module type definitions").green
-      end
+        declare module "*.module.scss" {
+          const classes: { [key: string]: string };
+          export default classes;
+        }
 
-      def create_typescript_config
-        tsconfig_content = {
-          "compilerOptions" => {
-            "target" => "es2018",
-            "lib" => ["dom", "dom.iterable", "es6"],
-            "allowJs" => true,
-            "skipLibCheck" => true,
-            "esModuleInterop" => true,
-            "allowSyntheticDefaultImports" => true,
-            "strict" => true,
-            "forceConsistentCasingInFileNames" => true,
-            "noFallthroughCasesInSwitch" => true,
-            "module" => "esnext",
-            "moduleResolution" => "node",
-            "resolveJsonModule" => true,
-            "isolatedModules" => true,
-            "noEmit" => true,
-            "jsx" => "react-jsx"
-          },
-          "include" => [
-            "app/javascript/**/*"
-          ],
-          "exclude" => [
-            "node_modules"
-          ]
+        declare module "*.module.sass" {
+          const classes: { [key: string]: string };
+          export default classes;
         }
+      TS
 
-        File.write("tsconfig.json", JSON.pretty_generate(tsconfig_content))
-        puts Rainbow("✅ Created tsconfig.json").green
-      end
+      File.write("app/javascript/types/css-modules.d.ts", css_module_types_content)
+      puts Rainbow("✅ Created CSS module type definitions").green
+    end
 
-      # Removed: Shakapacker auto-installation logic (now explicit dependency)
+    def create_typescript_config
+      tsconfig_content = {
+        "compilerOptions" => {
+          "target" => "es2018",
+          "lib" => ["dom", "dom.iterable", "es6"],
+          "allowJs" => true,
+          "skipLibCheck" => true,
+          "esModuleInterop" => true,
+          "allowSyntheticDefaultImports" => true,
+          "strict" => true,
+          "forceConsistentCasingInFileNames" => true,
+          "noFallthroughCasesInSwitch" => true,
+          "module" => "esnext",
+          "moduleResolution" => "node",
+          "resolveJsonModule" => true,
+          "isolatedModules" => true,
+          "noEmit" => true,
+          "jsx" => "react-jsx"
+        },
+        "include" => [
+          "app/javascript/**/*"
+        ],
+        "exclude" => [
+          "node_modules"
+        ]
+      }
 
-      # Removed: Shakapacker 8+ is now required as explicit dependency
+      File.write("tsconfig.json", JSON.pretty_generate(tsconfig_content))
+      puts Rainbow("✅ Created tsconfig.json").green
     end
+
+    # Removed: Shakapacker auto-installation logic (now explicit dependency)
+
+    # Removed: Shakapacker 8+ is now required as explicit dependency
     # rubocop:enable Metrics/ClassLength
   end
 end

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.client.tsx

@@ -5,7 +5,7 @@ import configureStore, { RailsProps } from '../store/helloWorldStore';
 import HelloWorldContainer from '../containers/HelloWorldContainer';
 
 // Props interface matches what Rails will pass from the controller
-type HelloWorldAppProps = RailsProps;
+interface HelloWorldAppProps extends RailsProps {}
 
 // See documentation for https://github.com/reactjs/react-redux.
 // This is how you get props from the Rails view into the redux store.