linting

Author: AbanoubGhadban

docs/api/javascript-api.md

@@ -59,7 +59,7 @@ The best source of docs is the main [ReactOnRails.ts](https://github.com/shakaco
   getStore(name, throwIfMissing = true )
 
   /**
-   * Renders or hydrates the react element passed. In case react version is >=18 will use the new api.
+   * Renders or hydrates the React element passed. In case React version is >=18 will use the root API.
    * @param domNode
    * @param reactElement
    * @param hydrate if true will perform hydration, if false will render

node_package/src/RSCClientRoot.ts

@@ -5,12 +5,12 @@ import RSDWClient from 'react-server-dom-webpack/client';
 import { fetch } from './utils';
 import transformRSCStreamAndReplayConsoleLogs from './transformRSCStreamAndReplayConsoleLogs';
 
-if (!('use' in React && typeof React.use === 'function')) {
+const { use } = React;
+
+if (typeof use !== 'function') {
   throw new Error('React.use is not defined. Please ensure you are using React 18 with experimental features enabled or React 19+ to use server components.');
 }
 
-const { use } = React;
-
 let renderCache: Record<string, Promise<React.ReactNode>> = {};
 export const resetRenderCache = () => {
   renderCache = {};

node_package/src/ReactOnRails.ts

@@ -105,7 +105,7 @@ ctx.ReactOnRails = {
   },
 
   /**
-   * Renders or hydrates the react element passed. In case react version is >=18 will use the new api.
+   * Renders or hydrates the React element passed. In case React version is >=18 will use the root API.
    * @param domNode
    * @param reactElement
    * @param hydrate if true will perform hydration, if false will render
@@ -287,7 +287,7 @@ ctx.ReactOnRails = {
   },
 
   /**
-   * Used by rsc payload generation by Rails
+   * Generates RSC payload, used by Rails
    */
   serverRenderRSCReactComponent() {
     throw new Error('serverRenderRSCReactComponent is supported in RSC bundle only.');

node_package/src/loadReactClientManifest.ts

@@ -1,7 +1,7 @@
 import path from 'path';
 import fs from 'fs';
 
-const loadedReactClientManifests = new Map<string, { [key: string]: unknown; }>();
+const loadedReactClientManifests = new Map<string, Record<string, unknown>>();
 
 export default function loadReactClientManifest(reactClientManifestFileName: string) {
   // React client manifest is uploaded to node renderer as an asset.

node_package/src/pageLifecycle.ts

@@ -7,24 +7,20 @@ import {
 } from './turbolinksUtils';
 
 type PageLifecycleCallback = () => void;
-enum PageState {
-  Load = 'load',
-  Unload = 'unload',
-  Initial = 0
-}
+type PageState = 'load' | 'unload' | 'initial';
 
 const pageLoadedCallbacks = new Set<PageLifecycleCallback>();
 const pageUnloadedCallbacks = new Set<PageLifecycleCallback>();
 
-let currentPageState: PageState = PageState.Initial;
+let currentPageState: PageState = 'initial';
 
 function runPageLoadedCallbacks(): void {
-  currentPageState = PageState.Load;
+  currentPageState = 'load';
   pageLoadedCallbacks.forEach((callback) => callback());
 }
 
 function runPageUnloadedCallbacks(): void {
-  currentPageState = PageState.Unload;
+  currentPageState = 'unload';
   pageUnloadedCallbacks.forEach((callback) => callback());
 }
 
@@ -78,15 +74,15 @@ function initializePageEventListeners(): void {
 }
 
 export function onPageLoaded(callback: PageLifecycleCallback): void {
-  if (currentPageState === PageState.Load) {
+  if (currentPageState === 'load') {
     callback();
   }
   pageLoadedCallbacks.add(callback);
   initializePageEventListeners();
 }
 
 export function onPageUnloaded(callback: PageLifecycleCallback): void {
-  if (currentPageState === PageState.Unload) {
+  if (currentPageState === 'unload') {
     callback();
   }
   pageUnloadedCallbacks.add(callback);