Skip to content

Commit 8f31aca

Browse files
justin808claude
andauthored
Pin Node.js to 22.11.0 to avoid V8 crash bug (#2095)
## Summary Pins Node.js version to 22.11.0 (LTS) in CI workflows to avoid a V8 bug that causes crashes during Will not publish package with `private: true` use --private flag to force publishing. and other operations. ## Changes - Pin to in lint-js-and-ruby workflow - Standardize Playwright workflow to use yarn run v1.22.22 info Commands available from binary scripts: acorn, attw, baseline-browser-mapping, browserslist, create-jest, cssesc, ejs, escodegen, esgenerate, eslint, eslint-config-prettier, esparse, esvalidate, github-codeowners, he, highlight, honeybadger-checkins-sync, import-local-fixture, jake, jest, jiti, js-yaml, jsesc, json5, knip, knip-bun, loose-envify, lz-string, marked, mime, mkdirp, nanoid, nodetouch, nps, parser, pino, pino-pretty, prettier, ps-tree, publint, regjsparser, resolve, semver, stylelint, ts-jest, tsc, tsserver, update-browserslist-db, uuid, which info Project commands - build yarn workspace react-on-rails run build && yarn workspace react-on-rails-pro run build - build-watch yarn workspaces run build-watch - check yarn run lint && yarn workspaces run check - clean yarn workspaces run clean - lint nps eslint - lint:scss stylelint "spec/dummy/app/assets/stylesheets/**/*.scss" "spec/dummy/client/**/*.scss" - postinstall test -f .lefthook.yml && test -d .git && command -v bundle >/dev/null 2>&1 && bundle exec lefthook install || true - publish yarn workspaces run publish - start nps - test yarn workspaces run test - type-check yarn workspaces run type-check - yalc yarn workspaces run yalc - yalc:publish yarn workspaces run yalc:publish Done in 0.03s. instead of bare yarn install v1.22.22 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... [4/4] Building fresh packages... $ test -f .lefthook.yml && test -d .git && command -v bundle >/dev/null 2>&1 && bundle exec lefthook install || true Done in 2.45s. commands for consistency ## References - Node.js V8 bug: nodejs/node#56010 ## Testing - ✅ No code changes, only CI configuration - ✅ Workflows will use pinned Node.js version on next run ## Context This is part of preparing for the monorepo node-renderer package. This small fix can merge independently. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated Node.js version pinning in build workflows to use a specific LTS patch version, improving build stability and consistency. * Standardized script invocation syntax in test workflows to align with best practices. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude <[email protected]>
1 parent d433348 commit 8f31aca

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/lint-js-and-ruby.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,9 @@ jobs:
9595
- name: Setup Node
9696
uses: ./.github/actions/setup-node-with-retry
9797
with:
98-
node-version: 22
98+
# Pin to 22.11.0 (LTS) to avoid V8 bug in 22.21.0
99+
# https://github.com/nodejs/node/issues/56010
100+
node-version: '22.11.0'
99101
cache: yarn
100102
cache-dependency-path: '**/yarn.lock'
101103
- name: Print system information

.github/workflows/playwright.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,11 @@ jobs:
7878

7979
- name: Build test assets
8080
working-directory: spec/dummy
81-
run: yarn build:test
81+
run: yarn run build:test
8282

8383
- name: Run Playwright tests
8484
working-directory: spec/dummy
85-
run: yarn test:e2e
85+
run: yarn run test:e2e
8686

8787
- uses: actions/upload-artifact@v4
8888
if: always()

0 commit comments

Comments
 (0)