Update changelog and configuration to reflect breaking changes and enhancements

- Added a breaking change note regarding the removal of `generated_assets_dirs` configuration, emphasizing the transition to Shakapacker for asset path management.
- Updated documentation in configuration.md to clarify the purpose of `components_subdirectory` for automatic component registration.
- Refactored version constants for Shakapacker compatibility, ensuring consistent terminology for auto-bundling features.

These changes improve clarity and guide users through the updated configuration requirements.

Author: AbanoubGhadban

CHANGELOG.md

@@ -23,6 +23,10 @@ After a release, please make sure to run `bundle exec rake update_changelog`. Th
 
 Changes since the last non-beta release.
 
+#### Breaking Changes
+
+- **Removed `generated_assets_dirs` configuration**: The legacy `config.generated_assets_dirs` option is no longer supported and will raise an error if used. Since Shakapacker is now required, asset paths are automatically determined from `shakapacker.yml` configuration. Remove any `config.generated_assets_dirs` from your `config/initializers/react_on_rails.rb` file. Use `public_output_path` in `config/shakapacker.yml` to customize asset output location instead. [PR 1798](https://github.com/shakacode/react_on_rails/pull/1798)
+
 #### New Features
 
 - **Server Bundle Security**: Added new configuration options for enhanced server bundle security and organization:
@@ -54,6 +58,7 @@ Changes since the last non-beta release.
 #### Bug Fixes
 
 - **Non-Packer Environment Compatibility**: Fixed potential NoMethodError when using bundle path resolution in environments without Shakapacker
+- **Shakapacker version requirements**: Fixed inconsistent version requirements between basic pack generation (6.5.1+) and advanced auto-bundling features (7.0.0+). Added backward compatibility for users on Shakapacker 6.5.1-6.9.x while providing clear upgrade guidance for advanced features. Added new constants `MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING` and improved version checking performance with caching. [PR 1798](https://github.com/shakacode/react_on_rails/pull/1798)
 
 ### [16.0.1-rc.2] - 2025-09-20
 

docs/guides/configuration.md

@@ -254,7 +254,7 @@ ReactOnRails.configure do |config|
   # | 8.2.0+            | ✅ Yes                | ✅ Yes             | ✅ Yes          | ✅ Yes         |
   #
   ################################################################################
-  # components_subdirectory is the name of the subdirectory matched to detect components for auto-bundle-loading
+  # components_subdirectory is the name of the subdirectory matched to detect and register components automatically
   # The default is nil. You can enable the feature by updating it in the next line.
   config.components_subdirectory = nil
   # Change to a value like this example to enable this feature

lib/react_on_rails/configuration.rb

@@ -144,7 +144,6 @@ def setup_config_values
       ensure_webpack_generated_files_exists
       configure_generated_assets_dirs_deprecation
       configure_skip_display_none_deprecation
-      ensure_generated_assets_dir_present
       check_server_render_method_is_only_execjs
       error_if_using_packer_and_generated_assets_dir_not_match_public_output_path
       # check_deprecated_settings
@@ -224,23 +223,17 @@ def validate_enforce_private_server_bundles
                                  "the public directory. Please set it to a directory outside of public."
     end
 
-    def check_autobundling_requirements
-      raise_missing_components_subdirectory if auto_load_bundle && !components_subdirectory.present?
-      return unless components_subdirectory.present?
-
-      # Check basic pack generation support for auto_load_bundle
+    def check_minimum_shakapacker_version
       ReactOnRails::PackerUtils.raise_shakapacker_version_incompatible_for_basic_pack_generation unless
         ReactOnRails::PackerUtils.supports_basic_pack_generation?
+    end
 
-      # Additional checks for advanced features requiring nested entries
-      if ReactOnRails::PackerUtils.supports_autobundling?
-        ReactOnRails::PackerUtils.raise_nested_entries_disabled unless ReactOnRails::PackerUtils.nested_entries?
-      else
-        # Warn users about missing advanced features but don't block basic functionality
-        min_version = ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION
-        Rails.logger.warn("React on Rails: Basic pack generation enabled. " \
-                          "Upgrade to Shakapacker #{min_version}+ for advanced auto-registration features.")
-      end
+    def check_autobundling_requirements
+      raise_missing_components_subdirectory unless components_subdirectory.present?
+
+      ReactOnRails::PackerUtils.raise_shakapacker_version_incompatible_for_autobundling unless
+        ReactOnRails::PackerUtils.supports_autobundling?
+      ReactOnRails::PackerUtils.raise_nested_entries_disabled unless ReactOnRails::PackerUtils.nested_entries?
     end
 
     def adjust_precompile_task
@@ -280,15 +273,15 @@ def error_if_using_packer_and_generated_assets_dir_not_match_public_output_path
 
       if File.expand_path(generated_assets_dir) == packer_public_output_path.to_s
         Rails.logger.warn("You specified generated_assets_dir in `config/initializers/react_on_rails.rb` " \
-                          "with shakapacker. " \
+                          "with Shakapacker. " \
                           "Remove this line from your configuration file.")
       else
         msg = <<~MSG
-          Configuration mismatch in config/initializers/react_on_rails.rb:
-
-          Your generated_assets_dir setting (#{generated_assets_dir}) does not match the value for public_output_path (#{packer_public_output_path}).
-
-          Remove the generated_assets_dir configuration and let Shakapacker manage the output path.
+          Error configuring /config/initializers/react_on_rails.rb: You are using Shakapacker
+          and your specified value for generated_assets_dir = #{generated_assets_dir}
+          that does not match the value for public_output_path specified in
+          shakapacker.yml = #{packer_public_output_path}. You should remove the configuration
+          value for "generated_assets_dir" from your config/initializers/react_on_rails.rb file.
         MSG
         raise ReactOnRails::Error, msg
       end
@@ -306,23 +299,20 @@ def check_server_render_method_is_only_execjs
       raise ReactOnRails::Error, msg
     end
 
-    def ensure_generated_assets_dir_present
-      return if generated_assets_dir.present?
-
-      # When using Shakapacker, don't set a default generated_assets_dir since
-      # Shakapacker manages its own public_output_path configuration
-      # This prevents configuration mismatches between ReactOnRails and Shakapacker
-      Rails.logger.warn "ReactOnRails: No generated_assets_dir specified, using Shakapacker public_output_path"
-    end
-
     def configure_generated_assets_dirs_deprecation
       return if generated_assets_dirs.blank?
 
       packer_public_output_path = ReactOnRails::PackerUtils.packer_public_output_path
-      Rails.logger.warn "You specified generated_assets_dirs in `config/initializers/react_on_rails.rb` " \
-                        "with Shakapacker. Remove this configuration as the output path is automatically " \
-                        "determined by `public_output_path` in shakapacker.yml " \
-                        "(currently: #{packer_public_output_path})."
+
+      msg = <<~MSG
+        ReactOnRails Configuration Error: The 'generated_assets_dirs' configuration option is no longer supported.
+        Since Shakapacker is now required, asset paths are automatically determined from your shakapacker.yml configuration.
+        Please remove 'config.generated_assets_dirs' from your config/initializers/react_on_rails.rb file.
+        Assets will be loaded from: #{packer_public_output_path}
+        If you need to customize the output path, configure it in config/shakapacker.yml under 'public_output_path'.
+      MSG
+
+      raise ReactOnRails::Error, msg
     end
 
     def ensure_webpack_generated_files_exists

lib/react_on_rails/packer_utils.rb

@@ -41,7 +41,7 @@ def self.supports_basic_pack_generation?
     end
 
     def self.supports_autobundling?
-      min_version = ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION
+      min_version = ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING
       ::Shakapacker.config.respond_to?(:nested_entries?) && shakapacker_version_requirement_met?(min_version)
     end
 
@@ -115,7 +115,7 @@ def self.check_manifest_not_cached
       msg = <<-MSG.strip_heredoc
           ERROR: you have enabled cache_manifest in the #{Rails.env} env when using the
           ReactOnRails::TestHelper.configure_rspec_to_compile_assets helper
-          To fix this: edit your config/shaka::Shakapacker.yml file and set cache_manifest to false for test.
+          To fix this: edit your config/shakapacker.yml file and set cache_manifest to false for test.
       MSG
       puts wrap_message(msg)
       exit!
@@ -135,8 +135,8 @@ def self.webpack_assets_status_checker
 
     def self.raise_nested_entries_disabled
       msg = <<~MSG
-        **ERROR** ReactOnRails: `nested_entries` is configured to be disabled in shaka::Shakapacker. Please update \
-        config/shaka::Shakapacker.yml to enable nested entries. for more information read
+        **ERROR** ReactOnRails: `nested_entries` is configured to be disabled in shakapacker. Please update \
+        config/shakapacker.yml to enable nested entries. for more information read
         https://www.shakacode.com/react-on-rails/docs/guides/file-system-based-automated-bundle-generation.md#enable-nested_entries-for-shakapacker
       MSG
 
@@ -145,7 +145,7 @@ def self.raise_nested_entries_disabled
 
     def self.raise_shakapacker_version_incompatible_for_autobundling
       msg = <<~MSG
-        **ERROR** ReactOnRails: Please upgrade ::Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION} or \
+        **ERROR** ReactOnRails: Please upgrade ::Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING} or \
         above to use the automated bundle generation feature (which requires nested_entries support). \
         The currently installed version is #{ReactOnRails::PackerUtils.shakapacker_version}. \
         Basic pack generation requires ::Shakapacker #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or above.
@@ -162,15 +162,5 @@ def self.raise_shakapacker_version_incompatible_for_basic_pack_generation
 
       raise ReactOnRails::Error, msg
     end
-
-    def self.raise_shakapacker_not_installed
-      msg = <<~MSG
-        **ERROR** ReactOnRails: Missing ::Shakapacker gem. Please upgrade to use ::Shakapacker \
-        #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or above to use the \
-        automated bundle generation feature.
-      MSG
-
-      raise ReactOnRails::Error, msg
-    end
   end
 end

lib/react_on_rails/packs_generator.rb

@@ -10,7 +10,7 @@ class PacksGenerator
     COMPONENT_EXTENSIONS = /\.(jsx?|tsx?)$/
     MINIMUM_SHAKAPACKER_VERSION = "6.5.1"
     # Auto-registration requires nested_entries support which was added in 7.0.0
-    MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION = "7.0.0"
+    MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING = "7.0.0"
 
     def self.instance
       @instance ||= PacksGenerator.new
@@ -166,7 +166,7 @@ def generated_server_pack_file_content
 
     def add_generated_pack_to_server_bundle
       return if ReactOnRails.configuration.make_generated_server_bundle_the_entrypoint
-      return if ReactOnRails.configuration.server_bundle_js_file.empty?
+      return if ReactOnRails.configuration.server_bundle_js_file.blank?
 
       relative_path_to_generated_server_bundle = relative_path(server_bundle_entrypoint,
                                                                generated_server_bundle_file_path)

lib/react_on_rails/system_checker.rb

@@ -622,10 +622,10 @@ def report_shakapacker_version_with_threshold
             Gem::Version.new(version)
 
             if ReactOnRails::PackerUtils.supports_autobundling?
-              add_success("✅ Shakapacker #{version} (supports React on Rails auto-registration)")
+              add_success("✅ Shakapacker #{version} (supports React on Rails auto-bundling)")
             else
               add_warning("⚠️  Shakapacker #{version} - Version 7.0+ with nested_entries support needed " \
-                          "for React on Rails auto-registration")
+                          "for React on Rails auto-bundling")
             end
           rescue ArgumentError
             # Fallback for invalid version strings

spec/react_on_rails/packer_utils_spec.rb

@@ -118,23 +118,23 @@ module ReactOnRails
       it "returns true when ::Shakapacker >= 7.0.0 with nested_entries support" do
         allow(mock_config).to receive(:respond_to?).with(:nested_entries?).and_return(true)
         allow(described_class).to receive(:shakapacker_version_requirement_met?)
-          .with(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION).and_return(true)
+          .with(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING).and_return(true)
 
         expect(described_class.supports_autobundling?).to be(true)
       end
 
       it "returns false when ::Shakapacker < 7.0.0" do
         allow(mock_config).to receive(:respond_to?).with(:nested_entries?).and_return(true)
         allow(described_class).to receive(:shakapacker_version_requirement_met?)
-          .with(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION).and_return(false)
+          .with(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING).and_return(false)
 
         expect(described_class.supports_autobundling?).to be(false)
       end
 
       it "returns false when nested_entries method is not available" do
         allow(mock_config).to receive(:respond_to?).with(:nested_entries?).and_return(false)
         allow(described_class).to receive(:shakapacker_version_requirement_met?)
-          .with(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION).and_return(true)
+          .with(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING).and_return(true)
 
         expect(described_class.supports_autobundling?).to be(false)
       end
@@ -144,13 +144,13 @@ module ReactOnRails
   describe "version constants validation" do
     it "ensures MINIMUM_SHAKAPACKER_VERSION constants are properly defined" do
       expect(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION).to eq("6.5.1")
-      expect(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION).to eq("7.0.0")
+      expect(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING).to eq("7.0.0")
     end
 
     it "ensures version requirements are logically consistent" do
       basic_version = Gem::Version.new(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION)
       auto_reg_version = Gem::Version.new(
-        ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_REGISTRATION
+        ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING
       )
 
       expect(auto_reg_version).to be >= basic_version,