linting

Author: AbanoubGhadban

react_on_rails_pro/app/helpers/react_on_rails_pro_helper.rb

@@ -266,7 +266,7 @@ def handle_stream_cache_hit(component_name, raw_options, auto_load_bundle, cache
 
   def handle_stream_cache_miss(component_name, raw_options, auto_load_bundle, view_cache_key, &block)
     cache_aware_options = raw_options.merge(
-      on_complete: ->(chunks) {
+      on_complete: lambda { |chunks|
         Rails.cache.write(view_cache_key, chunks, raw_options[:cache_options] || {})
       }
     )
@@ -308,15 +308,15 @@ def run_stream_inside_fiber(on_complete:)
 
     # Create a variable to hold the first chunk for synchronous return
     first_chunk_var = Async::Variable.new
-    all_chunks = [] if on_complete  # Only collect if callback provided
+    all_chunks = [] if on_complete # Only collect if callback provided
 
     # Start an async task on the barrier to stream all chunks
     @async_barrier.async do
       stream = yield
       is_first = true
 
       stream.each_chunk do |chunk|
-        all_chunks << chunk if on_complete  # Collect for callback
+        all_chunks << chunk if on_complete # Collect for callback
 
         if is_first
           # Store first chunk in variable for synchronous access
@@ -332,7 +332,7 @@ def run_stream_inside_fiber(on_complete:)
       first_chunk_var.value = nil if is_first
 
       # Call callback with all chunks when streaming completes
-      on_complete&.call(all_chunks) if on_complete
+      on_complete&.call(all_chunks)
     end
 
     # Wait for and return the first chunk (blocking)

react_on_rails_pro/spec/dummy/spec/helpers/react_on_rails_pro_helper_spec.rb

@@ -8,6 +8,8 @@
 
 RequestDetails = Struct.new(:original_url, :env)
 
+# rubocop:disable RSpec/InstanceVariable
+
 # This module is created to provide stub methods for `render_to_string` and `response`
 # These methods will be mocked in the tests to prevent "<object> does not implement <method>" errors
 # when these methods are called during testing.
@@ -387,7 +389,7 @@ def mock_request_and_response(mock_chunks = chunks, count: 1)
           expect(initial_result).to include(wrapped)
         end
         expect(initial_result).not_to include("More content", "Final content")
-        # Note: With async architecture, chunks are consumed in background immediately,
+        # NOTE: With async architecture, chunks are consumed in background immediately,
         expect(chunks_read.count).to eq(3)
       end
 
@@ -736,7 +738,7 @@ def render_cached_random_value(cache_key)
           @main_output_queue.close
 
           # Drain the queue
-          while (chunk = @main_output_queue.dequeue)
+          while @main_output_queue.dequeue
             # Just consume all remaining chunks
           end
         end
@@ -815,3 +817,4 @@ def render_cached_random_value(cache_key)
     end
   end
 end
+# rubocop:enable RSpec/InstanceVariable