Implement comprehensive doctor improvements based on user feedback

Major enhancements:
- Package manager shows actual version and deprecation status (yarn 1.22.22 + v1 deprecation note)
- Remove duplicate React on Rails gem version reporting
- Replace static configuration messages with actual shakapacker:info output
- Remove unnecessary "Server bundle configuration found" message
- Replace webpack version display with actionable inspection commands
- Add Open3-based package manager version detection with error handling
- Improve Shakapacker configuration section with real runtime data

Output improvements:
- Clean, non-redundant version information
- Actionable command suggestions (bin/shakapacker --print-config, ANALYZE=true)
- Comprehensive system information from shakapacker:info
- Better organization and reduced noise in recommendations

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/react_on_rails/doctor.rb

@@ -116,13 +116,12 @@ def check_environment
     end
 
     def check_react_on_rails_versions
-      check_gem_version
-      check_npm_package_version
+      # Use system_checker for comprehensive package validation instead of duplicating
+      checker.check_react_on_rails_packages
       check_version_wildcards
     end
 
     def check_packages
-      checker.check_react_on_rails_packages
       checker.check_shakapacker_configuration
     end
 
@@ -522,15 +521,36 @@ def check_key_configuration_files
       end
     end
 
+    # rubocop:disable Metrics/CyclomaticComplexity
     def check_shakapacker_configuration_details
       return unless File.exist?("config/shakapacker.yml")
 
-      # For now, just indicate that the configuration file exists
-      # TODO: Parse YAML directly or improve Shakapacker integration
       checker.add_info("📋 Shakapacker Configuration:")
-      checker.add_info("  Configuration file: config/shakapacker.yml")
-      checker.add_info("  ℹ️  Run 'rake shakapacker:info' for detailed configuration")
+
+      begin
+        # Run shakapacker:info to get detailed configuration
+        stdout, stderr, status = Open3.capture3("bundle", "exec", "rake", "shakapacker:info")
+
+        if status.success?
+          # Parse and display relevant info from shakapacker:info
+          lines = stdout.lines.map(&:strip)
+
+          lines.each do |line|
+            next if line.empty?
+
+            # Show key configuration lines
+            checker.add_info("  #{line}") if line.match?(%r{^(Ruby|Rails|Shakapacker|Node|yarn|Is bin/shakapacker)})
+          end
+        else
+          checker.add_info("  Configuration file: config/shakapacker.yml")
+          checker.add_warning("  ⚠️  Could not run 'rake shakapacker:info': #{stderr.strip}")
+        end
+      rescue StandardError => e
+        checker.add_info("  Configuration file: config/shakapacker.yml")
+        checker.add_warning("  ⚠️  Could not run 'rake shakapacker:info': #{e.message}")
+      end
     end
+    # rubocop:enable Metrics/CyclomaticComplexity
 
     def check_react_on_rails_configuration_details
       config_path = "config/initializers/react_on_rails.rb"

lib/react_on_rails/system_checker.rb

@@ -110,7 +110,11 @@ def check_package_manager
       # Detect which package manager is actually being used
       used_manager = detect_used_package_manager
       if used_manager
-        add_success("✅ Package manager in use: #{used_manager}")
+        version_info = get_package_manager_version(used_manager)
+        deprecation_note = get_deprecation_note(used_manager, version_info)
+        message = "✅ Package manager in use: #{used_manager} #{version_info}"
+        message += deprecation_note if deprecation_note
+        add_success(message)
       else
         add_success("✅ Package managers available: #{available_managers.join(', ')}")
         add_info("ℹ️  No lock file detected - run npm/yarn/pnpm install to establish which manager is used")
@@ -251,14 +255,6 @@ def check_react_on_rails_initializer
       initializer_path = "config/initializers/react_on_rails.rb"
       if File.exist?(initializer_path)
         add_success("✅ React on Rails initializer exists")
-
-        # Check for common configuration
-        content = File.read(initializer_path)
-        if content.include?("config.server_bundle_js_file")
-          add_success("✅ Server bundle configuration found")
-        else
-          add_info("ℹ️  Consider configuring server_bundle_js_file in initializer")
-        end
       else
         add_warning(<<~MSG.strip)
           ⚠️  React on Rails initializer not found.
@@ -275,7 +271,7 @@ def check_webpack_configuration
       if File.exist?(webpack_config_path)
         add_success("✅ Webpack configuration exists")
         check_webpack_config_content
-        report_webpack_version
+        suggest_webpack_inspection
       else
         add_error(<<~MSG.strip)
           🚫 Webpack configuration not found.
@@ -286,6 +282,11 @@ def check_webpack_configuration
       end
     end
 
+    def suggest_webpack_inspection
+      add_info("💡 To inspect webpack configuration: bin/shakapacker --print-config")
+      add_info("💡 To analyze bundle size: ANALYZE=true bin/shakapacker")
+    end
+
     def check_webpack_config_content
       webpack_config_path = "config/webpack/webpack.config.js"
       content = File.read(webpack_config_path)
@@ -331,6 +332,23 @@ def detect_used_package_manager
       end
     end
 
+    def get_package_manager_version(manager)
+      begin
+        stdout, _stderr, status = Open3.capture3(manager, "--version")
+        return stdout.strip if status.success? && !stdout.strip.empty?
+      rescue StandardError
+        # Ignore errors
+      end
+      "(version unknown)"
+    end
+
+    def get_deprecation_note(manager, version)
+      case manager
+      when "yarn"
+        " (Classic Yarn v1 - consider upgrading to Yarn Modern)" if /^1\./.match?(version)
+      end
+    end
+
     def shakapacker_configured?
       File.exist?("bin/shakapacker") &&
         File.exist?("bin/shakapacker-dev-server") &&