Refactor client startup and component loading behavior

- Changed the `reactOnRailsPageLoaded` function to return a resolved promise after invoking the startup logic, improving consistency in handling asynchronous operations.
- Updated the `reactOnRailsStoreLoaded` function to suppress unused variable warnings, enhancing code clarity.
- Added an ESLint directive to the `unmountAllComponents` function to address the use of deprecated APIs, ensuring better compliance with TypeScript standards.

These changes streamline the client-side rendering process and improve code quality.

Author: AbanoubGhadban

eslint.config.ts

@@ -151,7 +151,7 @@ const config = tsEslint.config([
     },
   },
   {
-    files: ['packages/react-on-rails/src/**/*'],
+    files: ['packages/**/src/**/*'],
     rules: {
       'import/extensions': ['error', 'ignorePackages'],
     },

packages/react-on-rails-pro/src/index.ts

@@ -17,6 +17,8 @@ export * from 'react-on-rails';
 
 // Import core ReactOnRails to enhance it
 import ReactOnRailsCore from 'react-on-rails/ReactOnRails.client';
+import { onPageLoaded, onPageUnloaded } from 'react-on-rails/pageLifecycle';
+import { debugTurbolinks } from 'react-on-rails/turbolinksUtils';
 
 // Import pro registries and features
 import type {
@@ -120,9 +122,6 @@ const ReactOnRailsPro = {
 globalThis.ReactOnRails = ReactOnRailsPro;
 
 // Pro client startup with immediate hydration support
-import { onPageLoaded, onPageUnloaded } from 'react-on-rails/pageLifecycle';
-import { debugTurbolinks } from 'react-on-rails/turbolinksUtils';
-
 export async function reactOnRailsPageLoaded() {
   debugTurbolinks('reactOnRailsPageLoaded [PRO]');
   // Pro: Render all components that don't have immediate_hydration

packages/react-on-rails/src/ClientRenderer.ts

@@ -182,6 +182,7 @@ function unmountAllComponents(): void {
         root.unmount();
       } else {
         // React 16-17 legacy API
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
         unmountComponentAtNode(domNode);
       }
     } catch (error) {

packages/react-on-rails/src/ReactOnRails.client.ts

@@ -89,14 +89,16 @@ globalThis.ReactOnRails = {
   },
 
   reactOnRailsPageLoaded() {
-    return ClientStartup.reactOnRailsPageLoaded();
+    ClientStartup.reactOnRailsPageLoaded();
+    return Promise.resolve();
   },
 
   reactOnRailsComponentLoaded(domId: string): Promise<void> {
     return reactOnRailsComponentLoaded(domId);
   },
 
-  reactOnRailsStoreLoaded(storeName: string): Promise<void> {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  reactOnRailsStoreLoaded(_storeName: string): Promise<void> {
     throw new Error('reactOnRailsStoreLoaded requires react-on-rails-pro package');
   },
 

packages/react-on-rails/src/clientStartup.ts

@@ -4,7 +4,7 @@ import { renderAllComponents } from './ClientRenderer.ts';
 import { onPageLoaded } from './pageLifecycle.ts';
 import { debugTurbolinks } from './turbolinksUtils.ts';
 
-export async function reactOnRailsPageLoaded() {
+export function reactOnRailsPageLoaded() {
   debugTurbolinks('reactOnRailsPageLoaded');
   // Core package: Render all components after page is fully loaded
   renderAllComponents();