Commit 9b4c722
HOTFIX: Add CI infrastructure pattern to ci-changes-detector (#2080)
## 🚨 URGENT HOTFIX for Master
This fixes the 9 failing detect-changes jobs on master caused by PR
#2077.
## Root Cause
PR #2077 added patterns for Pro test files BUT the ci-changes-detector
script itself was missing a pattern for CI infrastructure files
(`script/*`, `bin/*`, `.github/workflows/*`).
When PR #2077 merged (changing only `script/ci-changes-detector`):
1. Detector classified this as docs-only (ironically!)
2. ensure-master-docs-safety ran and found previous commit had failures
3. CI correctly failed to prevent false-positive "passing"
The safety mechanism worked correctly, but revealed a meta-problem:
**changes to CI infrastructure bypass CI validation**.
## Changes
- ✅ Add pattern for `script/*`, `bin/*`, `.github/workflows/*`,
`.github/actions/*`, `lefthook.yml`
- ✅ CI infrastructure changes now trigger ALL test suites
- ✅ Ensures changes to CI scripts are validated before merge
- ✅ Prevents the detector from bypassing its own detection
## Testing
```bash
# Before fix
echo "script/ci-changes-detector" | script/ci-changes-detector
# Output: ✓ Documentation-only changes
# After fix
echo "script/ci-changes-detector" | script/ci-changes-detector
# Output: Changed file categories:
# • Ruby source code
# • JavaScript/TypeScript code
# • Dummy app
# • Generators
# [... all test suites triggered]
```
## Impact
- Fixes 9 failing jobs on master immediately
- Completes the fix from PR #2077
- Ensures CI infrastructure changes are properly validated
- Prevents future meta-problems
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Enhanced CI infrastructure change detection to trigger comprehensive
test validation when CI configuration files are modified.
<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Co-authored-by: Claude <[email protected]>1 parent be024c0 commit 9b4c722
1 file changed
+13
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
141 | 154 | | |
142 | 155 | | |
143 | 156 | | |
| |||
0 commit comments