Skip to content

Commit 9b4c722

Browse files
justin808claude
andauthored
HOTFIX: Add CI infrastructure pattern to ci-changes-detector (#2080)
## 🚨 URGENT HOTFIX for Master This fixes the 9 failing detect-changes jobs on master caused by PR #2077. ## Root Cause PR #2077 added patterns for Pro test files BUT the ci-changes-detector script itself was missing a pattern for CI infrastructure files (`script/*`, `bin/*`, `.github/workflows/*`). When PR #2077 merged (changing only `script/ci-changes-detector`): 1. Detector classified this as docs-only (ironically!) 2. ensure-master-docs-safety ran and found previous commit had failures 3. CI correctly failed to prevent false-positive "passing" The safety mechanism worked correctly, but revealed a meta-problem: **changes to CI infrastructure bypass CI validation**. ## Changes - ✅ Add pattern for `script/*`, `bin/*`, `.github/workflows/*`, `.github/actions/*`, `lefthook.yml` - ✅ CI infrastructure changes now trigger ALL test suites - ✅ Ensures changes to CI scripts are validated before merge - ✅ Prevents the detector from bypassing its own detection ## Testing ```bash # Before fix echo "script/ci-changes-detector" | script/ci-changes-detector # Output: ✓ Documentation-only changes # After fix echo "script/ci-changes-detector" | script/ci-changes-detector # Output: Changed file categories: # • Ruby source code # • JavaScript/TypeScript code # • Dummy app # • Generators # [... all test suites triggered] ``` ## Impact - Fixes 9 failing jobs on master immediately - Completes the fix from PR #2077 - Ensures CI infrastructure changes are properly validated - Prevents future meta-problems 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Enhanced CI infrastructure change detection to trigger comprehensive test validation when CI configuration files are modified. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude <[email protected]>
1 parent be024c0 commit 9b4c722

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

script/ci-changes-detector

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,19 @@ while IFS= read -r file; do
138138
DOCS_ONLY=false
139139
PRO_LINT_CONFIG_CHANGED=true
140140
;;
141+
142+
# CI infrastructure files (scripts, workflows, CI configs)
143+
# Changes to CI infrastructure should trigger tests to validate the changes work
144+
script/*|script/**/*|bin/*|bin/**/*|.github/workflows/*|.github/actions/*|.github/actions/**/*|lefthook.yml)
145+
DOCS_ONLY=false
146+
RUBY_CHANGED=true # Trigger all tests for CI infrastructure changes
147+
JS_CHANGED=true
148+
SPEC_DUMMY_CHANGED=true
149+
GENERATORS_CHANGED=true
150+
PRO_RUBY_CHANGED=true
151+
PRO_JS_CHANGED=true
152+
PRO_DUMMY_CHANGED=true
153+
;;
141154
esac
142155
done <<< "$CHANGED_FILES"
143156

0 commit comments

Comments
 (0)