Add Redis service container with health checks for package-js-tests

Author: AbanoubGhadban

.github/workflows/pro-package-tests.yml

@@ -98,6 +98,17 @@ jobs:
   package-js-tests:
     needs: build-dummy-app-webpack-test-bundles
     runs-on: ubuntu-22.04
+    # Redis service container
+    services:
+      redis:
+        image: cimg/redis:6.2.6
+        ports:
+          - 6379:6379
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
     env:
       REACT_ON_RAILS_PRO_LICENSE: ${{ secrets.REACT_ON_RAILS_PRO_LICENSE }}
     steps:

react_on_rails_pro/packages/node-renderer/tests/redisClient.test.ts

@@ -1,3 +1,5 @@
+// This test in only for documenting Redis client usage
+
 import { createClient } from 'redis';
 
 const redisClient = createClient({ url: process.env.REDIS_URL || 'redis://localhost:6379' });

react_on_rails_pro/spec/dummy/client/app/utils/redisReceiver.ts

@@ -75,7 +75,7 @@ export function listenToRequestData(requestId: string): RequestListener {
     }
 
     // Create new listening promise
-    listenToStreamPromise = (async (): Promise<void> => {
+    const promise = (async (): Promise<void> => {
       if (isClosed) {
         throw new Error('Redis Connection is closed');
       }
@@ -123,10 +123,12 @@ export function listenToRequestData(requestId: string): RequestListener {
       }
     })();
 
-    return listenToStreamPromise.finally(() => {
+    listenToStreamPromise = promise.finally(() => {
       // Reset so next call creates new promise
       listenToStreamPromise = null;
     });
+
+    return listenToStreamPromise;
   }
 
   /**