Skip to content

Commit a1e23ec

Browse files
Refactor knip configuration and remove unused loadJsonFile function
- Updated the knip configuration for the react-on-rails and react-on-rails-pro packages, consolidating entry points and improving project structure. - Removed the obsolete loadJsonFile function from the ClientRenderer, streamlining the codebase and eliminating unnecessary complexity. - Adjusted ignore patterns to ensure proper handling of test utilities and build outputs. These changes enhance the organization and maintainability of the project.
1 parent 59d8f9b commit a1e23ec

File tree

3 files changed

+29
-53
lines changed

3 files changed

+29
-53
lines changed

knip.ts

Lines changed: 29 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -41,32 +41,44 @@ const config: KnipConfig = {
4141
'packages/react-on-rails': {
4242
entry: [
4343
'src/ReactOnRails.node.ts!',
44-
'src/pro/ReactOnRailsRSC.ts!',
45-
'src/pro/registerServerComponent/client.tsx!',
46-
'src/pro/registerServerComponent/server.tsx!',
47-
'src/pro/registerServerComponent/server.rsc.ts!',
48-
'src/pro/wrapServerComponentRenderer/server.tsx!',
49-
'src/pro/wrapServerComponentRenderer/server.rsc.tsx!',
50-
'src/pro/RSCRoute.tsx!',
51-
'src/pro/ServerComponentFetchError.ts!',
52-
'src/pro/getReactServerComponent.server.ts!',
53-
'src/pro/transformRSCNodeStream.ts!',
54-
'src/loadJsonFile.ts!',
44+
],
45+
project: ['src/**/*.[jt]s{x,}!', 'tests/**/*.[jt]s{x,}', '!lib/**'],
46+
ignore: [
47+
// Jest setup and test utilities - not detected by Jest plugin in workspace setup
48+
'tests/jest.setup.js',
49+
// Build output directories that should be ignored
50+
'lib/**',
51+
],
52+
},
53+
54+
// React on Rails Pro package workspace
55+
'packages/react-on-rails-pro': {
56+
entry: [
57+
'src/index.ts!',
58+
'src/ReactOnRailsRSC.ts!',
59+
'src/registerServerComponent/client.tsx!',
60+
'src/registerServerComponent/server.tsx!',
61+
'src/registerServerComponent/server.rsc.ts!',
62+
'src/wrapServerComponentRenderer/server.tsx!',
63+
'src/wrapServerComponentRenderer/server.rsc.tsx!',
64+
'src/RSCRoute.tsx!',
65+
'src/ServerComponentFetchError.ts!',
66+
'src/getReactServerComponent.server.ts!',
67+
'src/transformRSCNodeStream.ts!',
5568
],
5669
project: ['src/**/*.[jt]s{x,}!', 'tests/**/*.[jt]s{x,}', '!lib/**'],
5770
ignore: [
5871
'tests/emptyForTesting.js',
5972
// Jest setup and test utilities - not detected by Jest plugin in workspace setup
6073
'tests/jest.setup.js',
61-
'tests/testUtils.js',
6274
// Build output directories that should be ignored
6375
'lib/**',
6476
// Pro features exported for external consumption
65-
'src/pro/streamServerRenderedReactComponent.ts:transformRenderStreamChunksToResultObject',
66-
'src/pro/streamServerRenderedReactComponent.ts:streamServerRenderedComponent',
67-
'src/pro/ServerComponentFetchError.ts:isServerComponentFetchError',
68-
'src/pro/RSCRoute.tsx:RSCRouteProps',
69-
'src/pro/streamServerRenderedReactComponent.ts:StreamingTrackers',
77+
'src/streamServerRenderedReactComponent.ts:transformRenderStreamChunksToResultObject',
78+
'src/streamServerRenderedReactComponent.ts:streamServerRenderedComponent',
79+
'src/ServerComponentFetchError.ts:isServerComponentFetchError',
80+
'src/RSCRoute.tsx:RSCRouteProps',
81+
'src/streamServerRenderedReactComponent.ts:StreamingTrackers',
7082
],
7183
},
7284
'spec/dummy': {

packages/react-on-rails/src/ClientRenderer.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -133,15 +133,6 @@ export function renderComponent(domId: string): void {
133133
renderElement(el, railsContext);
134134
}
135135

136-
/**
137-
* Render all stores on the page.
138-
*/
139-
export function renderAllStores(): void {
140-
const railsContext = getRailsContext();
141-
if (!railsContext) return;
142-
forEachStore(railsContext);
143-
}
144-
145136
/**
146137
* Render all components on the page.
147138
* Core package renders all components after page load.

packages/react-on-rails/src/loadJsonFile.ts

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)