Commit a2a3d7b
Fix node-renderer package.json and knip configuration
This commit fixes multiple CI failures:
1. **Fix ESLint resolution errors:**
- Changed `main` entry from `lib/index.js` to `lib/ReactOnRailsProNodeRenderer.js`
- The package was trying to import from a non-existent index.js file
- ESLint was failing with "Cannot find module" errors
2. **Fix Knip dead code detection errors:**
- Added missing test dependencies to devDependencies:
- `redis`, `form-auto-content`, `form-data`, `node-html-parser`
- `sentry-testkit`, `touch`, `@jest/globals`, `@types/touch`
- Updated knip.ts with correct entry points for node-renderer:
- Changed from non-existent `src/index.ts` and `src/server.ts`
- To actual files: `ReactOnRailsProNodeRenderer.ts`, `default-node-renderer.ts`, `master.ts`, `worker.ts`
- Added test helper files to knip ignore list
3. **Updated yarn.lock** with new devDependencies
**Before:**
- ESLint: "Cannot find module .../lib/index.js"
- Knip: "Unlisted dependencies (9)" errors
- Build failures preventing tests from running
**After:**
- ESLint can resolve node-renderer imports
- Knip recognizes all dependencies as listed
- Build should succeed, allowing tests to run
These changes are part of Phase 5 monorepo migration to properly configure
the extracted node-renderer package at `packages/react-on-rails-pro-node-renderer/`.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent a573685 commit a2a3d7b
File tree
3 files changed
+512
-9
lines changed- packages/react-on-rails-pro-node-renderer
3 files changed
+512
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
77 | 80 | | |
78 | 81 | | |
79 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
53 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
54 | 62 | | |
55 | 63 | | |
56 | 64 | | |
| |||
0 commit comments