Refactor: Simplify asset path resolution for Pro RSC manifests in WebpackAssetsStatusChecker

Author: AbanoubGhadban

lib/react_on_rails/packer_utils.rb

@@ -58,7 +58,7 @@ def self.bundle_js_uri_from_packer(bundle_name)
       is_bundle_running_on_server = bundle_name == ReactOnRails.configuration.server_bundle_js_file
 
       # Check Pro RSC bundle if Pro is available
-      if ReactOnRails::Utils.react_on_rails_pro? && defined?(ReactOnRailsPro)
+      if ReactOnRails::Utils.react_on_rails_pro?
         is_bundle_running_on_server ||= (bundle_name == ReactOnRailsPro.configuration.rsc_bundle_js_file)
       end
 

lib/react_on_rails/test_helper/webpack_assets_status_checker.rb

@@ -47,22 +47,21 @@ def stale_generated_files(files)
 
       private
 
+      def resolve_asset_path(bundle_name)
+        # Check if this is a Pro RSC manifest file
+        if ReactOnRails::Utils.react_on_rails_pro?
+          pro_config = ReactOnRailsPro.configuration
+          return ReactOnRailsPro::Utils.react_client_manifest_file_path if bundle_name == pro_config.react_client_manifest_file
+          return ReactOnRailsPro::Utils.react_server_client_manifest_file_path if bundle_name == pro_config.react_server_client_manifest_file
+        end
+        
+        ReactOnRails::Utils.bundle_js_file_path(bundle_name)
+      end
+
       def all_compiled_assets
         @all_compiled_assets ||= begin
           webpack_generated_files = @webpack_generated_files.map do |bundle_name|
-            # Check if this is a Pro RSC manifest file
-            if ReactOnRails::Utils.react_on_rails_pro?
-              pro_config = ReactOnRailsPro.configuration
-              if bundle_name == pro_config.react_client_manifest_file
-                ReactOnRailsPro::Utils.react_client_manifest_file_path
-              elsif bundle_name == pro_config.react_server_client_manifest_file
-                ReactOnRailsPro::Utils.react_server_client_manifest_file_path
-              else
-                ReactOnRails::Utils.bundle_js_file_path(bundle_name)
-              end
-            else
-              ReactOnRails::Utils.bundle_js_file_path(bundle_name)
-            end
+            resolve_asset_path(bundle_name)
           end
 
           if webpack_generated_files.present?