Skip to content

Commit aa22d8d

Browse files
justin808claude
andcommitted
Fix CI failures: Update to Shakapacker 8.2.0 and improve test stubbing
- Updated gemspec to require shakapacker ~> 8.2 for async script loading support - Updated CI convert script to use Shakapacker 8.2.0 instead of 8.0.0 - Fixed file manager test by adding comprehensive File.exist? stubbing - This addresses the warnings about async script loading compatibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 093e4fe commit aa22d8d

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ PATH
77
execjs (~> 2.5)
88
rails (>= 5.2)
99
rainbow (~> 3.0)
10-
shakapacker (~> 8.0)
10+
shakapacker (~> 8.2)
1111

1212
GEM
1313
remote: https://rubygems.org/

react_on_rails.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Gem::Specification.new do |s|
3131
s.add_dependency "execjs", "~> 2.5"
3232
s.add_dependency "rails", ">= 5.2"
3333
s.add_dependency "rainbow", "~> 3.0"
34-
s.add_dependency "shakapacker", "~> 8.0"
34+
s.add_dependency "shakapacker", "~> 8.2"
3535

3636
s.add_development_dependency "gem-release"
3737
s.post_install_message = '

script/convert

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ end
1717
# Keep shakapacker.yml since we're using Shakapacker 8+
1818
# move("../spec/dummy/config/shakapacker.yml", "../spec/dummy/config/webpacker.yml")
1919

20-
# Shakapacker - use minimum supported version (8.0)
21-
gsub_file_content("../Gemfile.development_dependencies", /gem "shakapacker", "[^"]*"/, 'gem "shakapacker", "8.0.0"')
22-
gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "8.0.0",')
20+
# Shakapacker - use version with async script loading support (8.2.0+)
21+
gsub_file_content("../Gemfile.development_dependencies", /gem "shakapacker", "[^"]*"/, 'gem "shakapacker", "8.2.0"')
22+
gsub_file_content("../spec/dummy/package.json", /"shakapacker": "[^"]*",/, '"shakapacker": "8.2.0",')
2323

2424
# The below packages don't work on the oldest supported Node version and aren't needed there anyway
2525
gsub_file_content("../package.json", /"[^"]*eslint[^"]*": "[^"]*",?/, "")

spec/react_on_rails/dev/file_manager_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
end
2929

3030
it "removes stale overmind socket files" do
31+
allow(File).to receive(:exist?).and_return(false) # Default to false for any other files
3132
allow(File).to receive(:exist?).with(".overmind.sock").and_return(true)
3233
allow(File).to receive(:exist?).with("tmp/sockets/overmind.sock").and_return(false)
3334
allow(File).to receive(:exist?).with("tmp/pids/server.pid").and_return(false)

0 commit comments

Comments
 (0)