remove event listener multiple call test

Author: Judahmeek

packages/react-on-rails/src/pageLifecycle.ts

@@ -62,12 +62,11 @@ let isPageLifecycleInitialized = false;
 function onPageReady(callback: () => void) {
   if (typeof window === 'undefined') return;
 
-  if (isPageLifecycleInitialized) {
-    return;
-  }
-  isPageLifecycleInitialized = true;
-
   if (document.readyState === 'complete') {
+    if (isPageLifecycleInitialized) {
+      return;
+    }
+    isPageLifecycleInitialized = true;
     callback();
   } else {
     document.addEventListener('readystatechange', function onReadyStateChange() {

packages/react-on-rails/tests/pageLifecycle.test.js

@@ -232,25 +232,4 @@ describe('pageLifecycle', () => {
       global.window = originalWindow;
     });
   });
-
-  describe('preventing duplicate initialization', () => {
-    it('should not initialize listeners multiple times', () => {
-      setReadyState('loading');
-      const { onPageLoaded } = importPageLifecycle();
-      const callback1 = jest.fn();
-      const callback2 = jest.fn();
-
-      // First call should initialize and call addEventListener
-      onPageLoaded(callback1);
-      expect(addEventListenerSpy).toHaveBeenCalledTimes(1);
-
-      // Second call should not add more listeners (isPageLifecycleInitialized is true)
-      onPageLoaded(callback2);
-      expect(addEventListenerSpy).toHaveBeenCalledTimes(1);
-
-      // Both callbacks should be called
-      expect(callback1).not.toHaveBeenCalled();
-      expect(callback2).not.toHaveBeenCalled();
-    });
-  });
 });