Fix RuboCop violations in install generator and test files

- Fix line length violations in server_manager_spec.rb by breaking long lines
- Fix nested conditional violations in install_generator.rb by merging conditions
- Refactor shakapacker_in_gemfile? method to reduce complexity by extracting helper methods
- Add RuboCop disable/enable for class length in InstallGenerator

All tests still pass (72 examples, 0 failures).

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/install_generator.rb

@@ -6,6 +6,7 @@
 
 module ReactOnRails
   module Generators
+    # rubocop:disable Metrics/ClassLength
     class InstallGenerator < Rails::Generators::Base
       include GeneratorHelper
 
@@ -186,31 +187,12 @@ def ensure_shakapacker_installed
       # without loading it. Prioritizes Gemfile.lock (cheap + accurate),
       # then Bundler's resolved specs, and finally a light Gemfile scan.
       def shakapacker_in_gemfile?
-        gem_name  = "shakapacker"
-        gemfile   = ENV["BUNDLE_GEMFILE"] || "Gemfile"
-        lockfile  = File.join(File.dirname(gemfile), "Gemfile.lock")
+        gem_name = "shakapacker"
 
-        # 1) Already loaded in this process?
-        return true if Gem.loaded_specs.key?(gem_name)
-
-        # 2) Present in the lockfile? (handles git/path gems too)
-        if File.file?(lockfile)
-          # Lines look like: "    shakapacker (x.y.z)"
-          return true if File.foreach(lockfile).any? { |l| l.match?(/^\s{4}#{Regexp.escape(gem_name)}\s\(/) }
-        end
-
-        # 3) Ask Bundler for resolved specs (doesn't require the gem code)
-        begin
-          require "bundler"
-          return true if Bundler.load.specs.any? { |s| s.name == gem_name }
-        rescue StandardError
-          # Fall through if Bundler isn't available or load fails
-        end
-
-        # 4) Fallback: direct Gemfile mention (not perfect, but cheap)
-        if File.file?(gemfile)
-          return true if File.foreach(gemfile).any? { |l| l.match?(/^\s*gem\s+['"]#{Regexp.escape(gem_name)}['"]/) }
-        end
+        return true if shakapacker_loaded_in_process?(gem_name)
+        return true if shakapacker_in_lockfile?(gem_name)
+        return true if shakapacker_in_bundler_specs?(gem_name)
+        return true if shakapacker_in_gemfile_text?(gem_name)
 
         false
       end
@@ -232,9 +214,35 @@ def add_post_install_message
         GeneratorMessages.add_info(GeneratorMessages.helpful_message_after_installation)
       end
 
+      def shakapacker_loaded_in_process?(gem_name)
+        Gem.loaded_specs.key?(gem_name)
+      end
+
+      def shakapacker_in_lockfile?(gem_name)
+        gemfile = ENV["BUNDLE_GEMFILE"] || "Gemfile"
+        lockfile = File.join(File.dirname(gemfile), "Gemfile.lock")
+
+        File.file?(lockfile) && File.foreach(lockfile).any? { |l| l.match?(/^\s{4}#{Regexp.escape(gem_name)}\s\(/) }
+      end
+
+      def shakapacker_in_bundler_specs?(gem_name)
+        require "bundler"
+        Bundler.load.specs.any? { |s| s.name == gem_name }
+      rescue StandardError
+        false
+      end
+
+      def shakapacker_in_gemfile_text?(gem_name)
+        gemfile = ENV["BUNDLE_GEMFILE"] || "Gemfile"
+
+        File.file?(gemfile) &&
+          File.foreach(gemfile).any? { |l| l.match?(/^\s*gem\s+['"]#{Regexp.escape(gem_name)}['"]/) }
+      end
+
       # Removed: Shakapacker auto-installation logic (now explicit dependency)
 
       # Removed: Shakapacker 8+ is now required as explicit dependency
     end
+    # rubocop:enable Metrics/ClassLength
   end
 end

spec/react_on_rails/dev/server_manager_spec.rb

@@ -76,12 +76,16 @@ def mock_system_calls
     it "attempts to kill development processes" do
       # Mock Open3.capture2 calls that find_process_pids uses
       allow(Open3).to receive(:capture2).with("pgrep", "-f", "rails", err: File::NULL).and_return(["1234\n5678", nil])
-      allow(Open3).to receive(:capture2).with("pgrep", "-f", "node.*react[-_]on[-_]rails", err: File::NULL).and_return(["2345", nil])
+      allow(Open3).to receive(:capture2)
+        .with("pgrep", "-f", "node.*react[-_]on[-_]rails", err: File::NULL)
+        .and_return(["2345", nil])
       allow(Open3).to receive(:capture2).with("pgrep", "-f", "overmind", err: File::NULL).and_return(["", nil])
       allow(Open3).to receive(:capture2).with("pgrep", "-f", "foreman", err: File::NULL).and_return(["", nil])
       allow(Open3).to receive(:capture2).with("pgrep", "-f", "ruby.*puma", err: File::NULL).and_return(["", nil])
-      allow(Open3).to receive(:capture2).with("pgrep", "-f", "webpack-dev-server", err: File::NULL).and_return(["", nil])
-      allow(Open3).to receive(:capture2).with("pgrep", "-f", "bin/shakapacker-dev-server", err: File::NULL).and_return(["", nil])
+      allow(Open3).to receive(:capture2)
+        .with("pgrep", "-f", "webpack-dev-server", err: File::NULL).and_return(["", nil])
+      allow(Open3).to receive(:capture2)
+        .with("pgrep", "-f", "bin/shakapacker-dev-server", err: File::NULL).and_return(["", nil])
 
       allow(Process).to receive(:pid).and_return(9999) # Current process PID
       expect(Process).to receive(:kill).with("TERM", 1234)