Fix require order and improve React component performance

Redux Generator:
- Move GeneratorMessages require to top of file to fix load order
- Fix detect_package_manager calls to use proper module method
- Remove duplicate require statement in add_redux_specific_messages

React Component Improvements:
- Use modern JSX transform (remove React import)
- Add useMemo to prevent store recreation on re-renders
- Use type-only imports for better tree-shaking
- Switch from React.FC to FC import

Addresses additional code review feedback for performance and correctness.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/react_with_redux_generator.rb

@@ -2,6 +2,7 @@
 
 require "rails/generators"
 require_relative "generator_helper"
+require_relative "generator_messages"
 
 module ReactOnRails
   module Generators
@@ -82,7 +83,7 @@ def add_redux_npm_dependencies
         # Fallback to package manager detection if GeneratorHelper fails
         return if success
 
-        package_manager = detect_package_manager
+        package_manager = GeneratorMessages.detect_package_manager
         return unless package_manager
 
         install_packages_with_fallback(regular_packages, dev: false, package_manager: package_manager)
@@ -126,7 +127,6 @@ def build_install_command(package_manager, dev, packages_str)
 
       def add_redux_specific_messages
         # Override the generic messages with Redux-specific instructions
-        require_relative "generator_messages"
         GeneratorMessages.output.clear
         GeneratorMessages.add_info(
           GeneratorMessages.helpful_message_after_installation(component_name: "HelloWorldApp")

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.client.tsx

@@ -1,7 +1,7 @@
-import React from 'react';
+import { useMemo, type FC } from 'react';
 import { Provider } from 'react-redux';
 
-import configureStore, { RailsProps } from '../store/helloWorldStore';
+import configureStore, { type RailsProps } from '../store/helloWorldStore';
 import HelloWorldContainer from '../containers/HelloWorldContainer';
 
 // Props interface matches what Rails will pass from the controller
@@ -10,10 +10,14 @@ interface HelloWorldAppProps extends RailsProps {}
 // See documentation for https://github.com/reactjs/react-redux.
 // This is how you get props from the Rails view into the redux store.
 // This code here binds your smart component to the redux store.
-const HelloWorldApp: React.FC<HelloWorldAppProps> = (props) => (
-  <Provider store={configureStore(props)}>
-    <HelloWorldContainer />
-  </Provider>
-);
+const HelloWorldApp: FC<HelloWorldAppProps> = (props) => {
+  const store = useMemo(() => configureStore(props), [props]);
+
+  return (
+    <Provider store={store}>
+      <HelloWorldContainer />
+    </Provider>
+  );
+};
 
 export default HelloWorldApp;