Skip to content

Commit b6499ba

Browse files
alexeyrJudahmeek
authored andcommitted
More CI issues
1 parent a0097b7 commit b6499ba

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

.github/workflows/package-js-tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ jobs:
3838
- name: Install Node modules with Yarn for renderer package
3939
run: |
4040
yarn install --no-progress --no-emoji
41-
yarn run eslint -v
4241
sudo yarn global add yalc
4342
- name: Run JS unit tests for Renderer package
4443
run: yarn test

eslint.config.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ const config = tsEslint.config([
2121
'spec/dummy/vendor',
2222
'spec/dummy/tmp',
2323
'spec/dummy/app/assets/config/manifest.js',
24+
'spec/dummy/client/app/packs/server-bundle.js',
2425
'**/*.res.js',
2526
'**/coverage',
2627
'**/node_modules/**/*',
@@ -93,6 +94,12 @@ const config = tsEslint.config([
9394
// The rule seems broken: it's reporting errors on imports in files using `export` too,
9495
// not just `module.exports`.
9596
'import/no-import-module-exports': 'off',
97+
'import/no-unresolved': [
98+
'error',
99+
{
100+
ignore: ['\\.res\\.js$'],
101+
},
102+
],
96103
'react/destructuring-assignment': [
97104
'error',
98105
'always',

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@
8282
"type-check": "yarn run tsc --noEmit --noErrorTruncation",
8383
"release:patch": "node_package/scripts/release patch",
8484
"release:minor": "node_package/scripts/release minor",
85-
"release:major": "node_package/scripts/release major",
86-
"knip": "knip"
85+
"release:major": "node_package/scripts/release major"
8786
},
8887
"repository": {
8988
"type": "git",

spec/dummy/client/app/packs/server-bundle.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// import statement added by react_on_rails:generate_packs rake task
2-
import '../generated/server-bundle-generated.js'; // eslint-disable-line import/extensions
2+
import './../generated/server-bundle-generated.js'; // eslint-disable-line import/extensions
33
// Shows the mapping from the exported object to the name used by the server rendering.
44
import ReactOnRails from 'react-on-rails';
55
// Example of server rendering with no React

0 commit comments

Comments
 (0)