Fix RuboCop violations and refactor complex methods

Code Quality Improvements:
- Fix Style/GuardClause violations in BaseGenerator dependency methods
- Fix Layout/EmptyLineAfterGuardClause violations in InstallGenerator
- Refactor ensure_shakapacker_installed method to reduce cyclomatic complexity
- Extract helper methods for better readability and maintainability:
  * shakapacker_binaries_exist?
  * print_shakapacker_setup_banner
  * ensure_shakapacker_in_gemfile
  * install_shakapacker
  * finalize_shakapacker_setup
  * handle_shakapacker_gemfile_error
  * handle_shakapacker_install_error

This addresses the code quality concerns about complex methods and ensures
all Ruby code follows the project's style guidelines.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/base_generator.rb

@@ -187,10 +187,10 @@ def add_react_dependencies
           babel-plugin-transform-react-remove-prop-types
           babel-plugin-macros
         ]
-        unless add_npm_dependencies(react_deps)
-          success = run "npm install #{react_deps.join(' ')}"
-          handle_npm_failure("React dependencies", react_deps) unless success
-        end
+        return if add_npm_dependencies(react_deps)
+
+        success = run "npm install #{react_deps.join(' ')}"
+        handle_npm_failure("React dependencies", react_deps) unless success
       end
 
       def add_css_dependencies
@@ -201,10 +201,10 @@ def add_css_dependencies
           mini-css-extract-plugin
           style-loader
         ]
-        unless add_npm_dependencies(css_deps)
-          success = run "npm install #{css_deps.join(' ')}"
-          handle_npm_failure("CSS dependencies", css_deps) unless success
-        end
+        return if add_npm_dependencies(css_deps)
+
+        success = run "npm install #{css_deps.join(' ')}"
+        handle_npm_failure("CSS dependencies", css_deps) unless success
       end
 
       def add_dev_dependencies

lib/generators/react_on_rails/install_generator.rb

@@ -118,71 +118,12 @@ def check_node_version
       end
 
       def ensure_shakapacker_installed
-        return if File.exist?("bin/shakapacker") && File.exist?("bin/shakapacker-dev-server")
+        return if shakapacker_binaries_exist?
 
-        puts Rainbow("\n#{'=' * 80}").cyan
-        puts Rainbow("🔧 SHAKAPACKER SETUP").cyan.bold
-        puts Rainbow("=" * 80).cyan
-
-        # Add Shakapacker to Gemfile if not present
-        unless shakapacker_in_gemfile?
-          puts Rainbow("📝 Adding Shakapacker to Gemfile...").yellow
-          success = system("bundle add shakapacker --strict")
-          unless success
-            error = <<~MSG.strip
-              🚫 Failed to add Shakapacker to your Gemfile.
-
-              This could be due to:
-              • Bundle installation issues
-              • Network connectivity problems
-              • Gemfile permissions
-
-              Please try manually:
-                  bundle add shakapacker --strict
-
-              Then re-run: rails generate react_on_rails:install
-            MSG
-            GeneratorMessages.add_error(error)
-            raise Thor::Error, error unless options.ignore_warnings?
-            return
-          end
-          puts Rainbow("✅ Shakapacker added to Gemfile successfully!").green
-        end
-
-        # Install Shakapacker
-        puts Rainbow("⚙️  Installing Shakapacker (required for webpack integration)...").yellow
-        success = system("./bin/rails shakapacker:install")
-
-        unless success
-          error = <<~MSG.strip
-            🚫 Failed to install Shakapacker automatically.
-
-            This could be due to:
-            • Missing Node.js or npm/yarn
-            • Network connectivity issues
-            • Incomplete bundle installation
-            • Missing write permissions
-
-            Troubleshooting steps:
-            1. Ensure Node.js is installed: node --version
-            2. Try manually: ./bin/rails shakapacker:install
-            3. Check for error output above
-            4. Re-run: rails generate react_on_rails:install
-
-            Need help? Visit: https://github.com/shakacode/shakapacker/blob/main/docs/installation.md
-          MSG
-          GeneratorMessages.add_error(error)
-          raise Thor::Error, error unless options.ignore_warnings?
-          return
-        end
-
-        puts Rainbow("✅ Shakapacker installed successfully!").green
-        puts Rainbow("=" * 80).cyan
-        puts Rainbow("🚀 CONTINUING WITH REACT ON RAILS SETUP").cyan.bold
-        puts "#{Rainbow('=' * 80).cyan}\n"
-
-        # Create marker file so base generator can avoid copying shakapacker.yml
-        File.write(".shakapacker_just_installed", "")
+        print_shakapacker_setup_banner
+        ensure_shakapacker_in_gemfile
+        install_shakapacker
+        finalize_shakapacker_setup
       end
 
       # Checks whether "shakapacker" is present in the *current bundle*,
@@ -245,6 +186,88 @@ def cli_exists?(command)
         system("which #{command} > /dev/null 2>&1")
       end
 
+      def shakapacker_binaries_exist?
+        File.exist?("bin/shakapacker") && File.exist?("bin/shakapacker-dev-server")
+      end
+
+      def print_shakapacker_setup_banner
+        puts Rainbow("\n#{'=' * 80}").cyan
+        puts Rainbow("🔧 SHAKAPACKER SETUP").cyan.bold
+        puts Rainbow("=" * 80).cyan
+      end
+
+      def ensure_shakapacker_in_gemfile
+        return if shakapacker_in_gemfile?
+
+        puts Rainbow("📝 Adding Shakapacker to Gemfile...").yellow
+        success = system("bundle add shakapacker --strict")
+        return if success
+
+        handle_shakapacker_gemfile_error
+      end
+
+      def install_shakapacker
+        puts Rainbow("⚙️  Installing Shakapacker (required for webpack integration)...").yellow
+        success = system("./bin/rails shakapacker:install")
+        return if success
+
+        handle_shakapacker_install_error
+      end
+
+      def finalize_shakapacker_setup
+        puts Rainbow("✅ Shakapacker installed successfully!").green
+        puts Rainbow("=" * 80).cyan
+        puts Rainbow("🚀 CONTINUING WITH REACT ON RAILS SETUP").cyan.bold
+        puts "#{Rainbow('=' * 80).cyan}\n"
+
+        # Create marker file so base generator can avoid copying shakapacker.yml
+        File.write(".shakapacker_just_installed", "")
+      end
+
+      def handle_shakapacker_gemfile_error
+        error = <<~MSG.strip
+          🚫 Failed to add Shakapacker to your Gemfile.
+
+          This could be due to:
+          • Bundle installation issues
+          • Network connectivity problems
+          • Gemfile permissions
+
+          Please try manually:
+              bundle add shakapacker --strict
+
+          Then re-run: rails generate react_on_rails:install
+        MSG
+        GeneratorMessages.add_error(error)
+        raise Thor::Error, error unless options.ignore_warnings?
+
+        return
+      end
+
+      def handle_shakapacker_install_error
+        error = <<~MSG.strip
+          🚫 Failed to install Shakapacker automatically.
+
+          This could be due to:
+          • Missing Node.js or npm/yarn
+          • Network connectivity issues
+          • Incomplete bundle installation
+          • Missing write permissions
+
+          Troubleshooting steps:
+          1. Ensure Node.js is installed: node --version
+          2. Try manually: ./bin/rails shakapacker:install
+          3. Check for error output above
+          4. Re-run: rails generate react_on_rails:install
+
+          Need help? Visit: https://github.com/shakacode/shakapacker/blob/main/docs/installation.md
+        MSG
+        GeneratorMessages.add_error(error)
+        raise Thor::Error, error unless options.ignore_warnings?
+
+        return
+      end
+
       def missing_package_manager?
         package_managers = %w[npm pnpm yarn bun]
         missing = package_managers.none? { |pm| cli_exists?(pm) }