Commit bae4005
Add documentation for memory tradeoff and retry handling
Addresses code review feedback:
1. Memory Management: Document that we maintain two separate HTTP connection
pools (with and without retries), which doubles the memory footprint.
This tradeoff is acceptable to prevent body duplication in streaming responses.
2. Retry Logic: Add comment in stream_request.rb explaining that retry logic
for streaming requests is handled by starting fresh requests, and the HTTPx
connection has retries disabled to prevent body duplication.
These comments improve code maintainability by explaining the architectural
decisions and their tradeoffs.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 64c9dec commit bae4005
File tree
2 files changed
+7
-0
lines changed- react_on_rails_pro/lib/react_on_rails_pro
2 files changed
+7
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
87 | 91 | | |
88 | 92 | | |
89 | 93 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
78 | 81 | | |
79 | 82 | | |
80 | 83 | | |
| |||
0 commit comments