fix redux generator for auto-registration

- Implement auto-registration structure for Redux (HelloWorldApp component)
- Fix component naming consistency (HelloWorld → HelloWorldApp for Redux)
- Update directory structure to src/HelloWorldApp/ror_components/
- Fix import paths for new auto-registration structure
- Remove manual bundle creation (eliminate hello-world-bundle.js)
- Add cleanup of conflicting base generator files

this is because before it, manual registration and non redux HelloWorld component were created even when specifying --redux

Author: ihabadham

lib/generators/react_on_rails/generator_messages.rb

@@ -38,17 +38,18 @@ def clear
       @output = []
     end
 
-    def helpful_message_after_installation
+    def helpful_message_after_installation(component_name: "HelloWorld")
       <<~MSG
 
         What to do next:
 
           - See the documentation on https://github.com/shakacode/shakapacker#webpack-configuration
             for how to customize the default webpack configuration.
 
-          - Include your webpack assets to your application layout.
+          - No manual pack tags needed with auto-registration! Your layout should use empty pack tags:
 
-              <%= javascript_pack_tag 'hello-world-bundle' %>
+              <%= javascript_pack_tag %>
+              <%= stylesheet_pack_tag %>
 
           - To start Rails server run:
 
@@ -61,7 +62,7 @@ def helpful_message_after_installation
           - To server render, change this line app/views/hello_world/index.html.erb to
             `prerender: true` to see server rendering (right click on page and select "view source").
 
-              <%= react_component("HelloWorld", props: @hello_world_props, prerender: true) %>
+              <%= react_component("#{component_name}", props: @hello_world_props, prerender: true) %>
 
         Alternative steps to run the app:
 

lib/generators/react_on_rails/react_with_redux_generator.rb

@@ -9,29 +9,30 @@ class ReactWithReduxGenerator < Rails::Generators::Base
       source_root(File.expand_path("templates", __dir__))
 
       def create_redux_directories
-        dirs = %w[actions constants containers reducers store startup]
-        dirs.each { |name| empty_directory("app/javascript/bundles/HelloWorld/#{name}") }
+        # Create auto-registration directory structure for Redux
+        empty_directory("app/javascript/src/HelloWorldApp/ror_components")
+        
+        # Create Redux support directories within the component directory
+        dirs = %w[actions constants containers reducers store]
+        dirs.each { |name| empty_directory("app/javascript/src/HelloWorldApp/#{name}") }
       end
 
       def copy_base_files
         base_js_path = "redux/base"
-        base_files = %w[app/javascript/bundles/HelloWorld/components/HelloWorld.jsx
-                        app/javascript/bundles/HelloWorld/components/HelloWorld.module.css]
-        base_files.each { |file| copy_file("#{base_js_path}/#{file}", file) }
-
-        # Also copy Redux-connected component to auto-registration structure
+        
+        # Copy Redux-connected component to auto-registration structure
         copy_file("#{base_js_path}/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.client.jsx",
-                  "app/javascript/src/HelloWorld/ror_components/HelloWorld.client.jsx")
+                  "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.jsx")
         copy_file("#{base_js_path}/app/javascript/bundles/HelloWorld/startup/HelloWorldApp.server.jsx",
-                  "app/javascript/src/HelloWorld/ror_components/HelloWorld.server.jsx")
+                  "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.server.jsx")
         copy_file("#{base_js_path}/app/javascript/bundles/HelloWorld/components/HelloWorld.module.css",
-                  "app/javascript/src/HelloWorld/HelloWorld.module.css")
+                  "app/javascript/src/HelloWorldApp/HelloWorldApp.module.css")
 
         # Update import paths in client component
-        ror_client_file = "app/javascript/src/HelloWorld/ror_components/HelloWorld.client.jsx"
-        gsub_file(ror_client_file, "../store/helloWorldStore", "../../../bundles/HelloWorld/store/helloWorldStore")
+        ror_client_file = "app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.jsx"
+        gsub_file(ror_client_file, "../store/helloWorldStore", "../store/helloWorldStore")
         gsub_file(ror_client_file, "../containers/HelloWorldContainer",
-                  "../../../bundles/HelloWorld/containers/HelloWorldContainer")
+                  "../containers/HelloWorldContainer")
       end
 
       def copy_base_redux_files
@@ -40,29 +41,42 @@ def copy_base_redux_files
            containers/HelloWorldContainer.js
            constants/helloWorldConstants.js
            reducers/helloWorldReducer.js
-           store/helloWorldStore.js
-           startup/HelloWorldApp.client.jsx
-           startup/HelloWorldApp.server.jsx].each do |file|
+           store/helloWorldStore.js].each do |file|
              copy_file("#{base_hello_world_path}/#{file}",
-                       "app/javascript/bundles/HelloWorld/#{file}")
+                       "app/javascript/src/HelloWorldApp/#{file}")
            end
       end
 
       def create_appropriate_templates
         base_path = "base/base"
-        base_js_path = "#{base_path}/app/javascript"
         config = {
-          component_name: "HelloWorld",
-          app_relative_path: "../bundles/HelloWorld/startup/HelloWorldApp.client"
+          component_name: "HelloWorldApp"
         }
 
-        template("#{base_js_path}/packs/registration.js.tt", "app/javascript/packs/hello-world-bundle.js", config)
-        template("#{base_path}/app/views/hello_world/index.html.erb.tt", "app/views/hello_world/index.html.erb", config)
+        # Only create the view template - no manual bundle needed for auto registration
+        template("#{base_path}/app/views/hello_world/index.html.erb.tt",
+                 "app/views/hello_world/index.html.erb", config)
       end
 
       def add_redux_yarn_dependencies
         run "yarn add redux react-redux"
       end
+
+      def cleanup_base_generator_files
+        # Remove files created by base generator since Redux uses different structure
+        remove_file "app/javascript/src/HelloWorld/HelloWorld.module.css"
+        remove_dir "app/javascript/src/HelloWorld/ror_components" if Dir.exist?("app/javascript/src/HelloWorld/ror_components") && Dir.empty?("app/javascript/src/HelloWorld/ror_components")
+        remove_dir "app/javascript/src/HelloWorld" if Dir.exist?("app/javascript/src/HelloWorld") && Dir.entries("app/javascript/src/HelloWorld").size <= 2 # only . and ..
+      end
+
+      def add_redux_specific_messages
+        # Override the generic messages with Redux-specific instructions
+        require_relative "generator_messages"
+        GeneratorMessages.output.clear
+        GeneratorMessages.add_info(
+          GeneratorMessages.helpful_message_after_installation(component_name: "HelloWorldApp")
+        )
+      end
     end
   end
 end