Commit bcf084c
Clean solution: Remove redundant using_packer? check with proper test handling
Since Shakapacker is required by gemspec, the using_packer? check in
bundle_js_file_path is unnecessary for production code. However, tests
mock this scenario for validation.
Changes:
- Remove using_packer? check from main bundle_js_file_path logic
- Add guard check in bundle_js_file_path_with_packer for test scenarios
- Maintains clean production code while handling test mocking properly
- All tests pass including "without packer" scenarios
This is the correct approach: main logic assumes Shakapacker is available
(as guaranteed by gemspec), while method implementation handles edge cases
for comprehensive test coverage.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>1 parent ff9cc79 commit bcf084c
1 file changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
86 | 89 | | |
87 | 90 | | |
88 | 91 | | |
| |||
0 commit comments