Skip to content

Commit c09199e

Browse files
remove unneeded call to buildConfig function
1 parent 6c0271a commit c09199e

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

react_on_rails_pro/packages/node-renderer/tests/helper.ts

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -67,22 +67,12 @@ export function vmSecondaryBundlePath(testName: string) {
6767

6868
export async function createVmBundle(testName: string) {
6969
// Build config with module support before creating VM bundle
70-
buildConfig({
71-
serverBundleCachePath: serverBundleCachePath(testName),
72-
supportModules: true,
73-
stubTimers: false,
74-
});
7570
await safeCopyFileAsync(getFixtureBundle(), vmBundlePath(testName));
7671
await buildExecutionContext([vmBundlePath(testName)], /* buildVmsIfNeeded */ true);
7772
}
7873

7974
export async function createSecondaryVmBundle(testName: string) {
8075
// Build config with module support before creating VM bundle
81-
buildConfig({
82-
serverBundleCachePath: serverBundleCachePath(testName),
83-
supportModules: true,
84-
stubTimers: false,
85-
});
8676
await safeCopyFileAsync(getFixtureSecondaryBundle(), vmSecondaryBundlePath(testName));
8777
await buildExecutionContext([vmSecondaryBundlePath(testName)], /* buildVmsIfNeeded */ true);
8878
}
@@ -170,10 +160,12 @@ export async function createAsset(testName: string, bundleTimestamp: string) {
170160
]);
171161
}
172162

173-
export async function resetForTest(testName: string) {
163+
export async function resetForTest(testName: string, resetConfigs = true) {
174164
await fsExtra.emptyDir(serverBundleCachePath(testName));
175165
resetVM();
176-
setConfig(testName);
166+
if (resetConfigs) {
167+
setConfig(testName);
168+
}
177169
}
178170

179171
export function readRenderingRequest(projectName: string, commit: string, requestDumpFileName: string) {
@@ -231,5 +223,3 @@ export const waitFor = async (
231223
const defaultMessage = `Expect condition not met within ${timeout}ms`;
232224
throw new Error(message || defaultMessage + (lastError ? `\nLast error: ${lastError.message}` : ''));
233225
};
234-
235-
setConfig('helper');

react_on_rails_pro/packages/node-renderer/tests/incrementalRender.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ describe('incremental render NDJSON endpoint', () => {
239239
};
240240

241241
beforeEach(async () => {
242-
await resetForTest(TEST_NAME);
242+
await resetForTest(TEST_NAME, false);
243243
});
244244

245245
afterEach(() => {

0 commit comments

Comments
 (0)