Remove --frozen-lockfile from dummy app install after yalc

The yalc workflow modifies yarn.lock when adding packages, so we cannot
use --frozen-lockfile after yalc has run. Keep --ignore-scripts to skip
the preinstall hook (since yalc already ran in the previous step).

This allows the install to succeed after yalc has modified the lockfile.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

.github/workflows/pro-integration-tests.yml

@@ -75,7 +75,7 @@ jobs:
           yarn && yalc publish
 
       - name: Install Node modules with Yarn for Pro dummy app
-        run: cd spec/dummy && yarn install --frozen-lockfile --ignore-scripts --no-progress --no-emoji
+        run: cd spec/dummy && yarn install --ignore-scripts --no-progress --no-emoji
 
       - name: Install Ruby Gems for Pro dummy app
         run: |
@@ -195,7 +195,7 @@ jobs:
           yarn && yalc publish
 
       - name: Install Node modules with Yarn for Pro dummy app
-        run: cd spec/dummy && yarn install --frozen-lockfile --ignore-scripts --no-progress --no-emoji
+        run: cd spec/dummy && yarn install --ignore-scripts --no-progress --no-emoji
 
       - name: Ensure minimum required Chrome version
         run: |
@@ -387,7 +387,7 @@ jobs:
           yarn && yalc publish
 
       - name: Install Node modules with Yarn for Pro dummy app
-        run: cd spec/dummy && yarn install --frozen-lockfile --ignore-scripts --no-progress --no-emoji
+        run: cd spec/dummy && yarn install --ignore-scripts --no-progress --no-emoji
 
       - name: Ensure minimum required Chrome version
         run: |

lib/generators/react_on_rails/templates/base/base/bin/shakapacker-precompile-hook

@@ -0,0 +1,70 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+# Shakapacker precompile hook
+# This script runs before Shakapacker compilation in both development and production.
+# See: https://github.com/shakacode/shakapacker/blob/main/docs/precompile_hook.md
+
+require "fileutils"
+
+# Build ReScript if needed
+def build_rescript_if_needed
+  # Check for both old (bsconfig.json) and new (rescript.json) config files
+  return unless File.exist?("bsconfig.json") || File.exist?("rescript.json")
+
+  puts "🔧 Building ReScript..."
+
+  # Try to find the ReScript build command
+  if system("command -v yarn > /dev/null 2>&1")
+    success = system("yarn build:rescript")
+  elsif system("command -v npm > /dev/null 2>&1")
+    success = system("npm run build:rescript")
+  else
+    warn "⚠️  Warning: Neither yarn nor npm found. Skipping ReScript build."
+    return
+  end
+
+  if success
+    puts "✅ ReScript build completed successfully"
+  else
+    warn "❌ ReScript build failed"
+    exit 1
+  end
+end
+
+# Generate React on Rails packs if needed
+def generate_packs_if_needed
+  return unless File.exist?("config/initializers/react_on_rails.rb")
+
+  # Check if auto-pack generation is configured
+  config_file = File.read("config/initializers/react_on_rails.rb")
+  return unless config_file.include?("auto_load_bundle") || config_file.include?("components_subdirectory")
+
+  puts "📦 Generating React on Rails packs..."
+
+  # Check if bundle and rake task are available
+  bundle_available = system("command -v bundle > /dev/null 2>&1")
+  rake_task_exists = system("bundle exec rails -T | grep -q react_on_rails:generate_packs")
+  return unless bundle_available && rake_task_exists
+
+  success = system("bundle exec rails react_on_rails:generate_packs")
+
+  if success
+    puts "✅ Pack generation completed successfully"
+  else
+    warn "❌ Pack generation failed"
+    exit 1
+  end
+end
+
+# Main execution
+begin
+  build_rescript_if_needed
+  generate_packs_if_needed
+
+  exit 0
+rescue StandardError => e
+  warn "❌ Precompile hook failed: #{e.message}"
+  warn e.backtrace.join("\n")
+  exit 1
+end

lib/generators/react_on_rails/templates/base/base/config/shakapacker.yml

@@ -4,6 +4,10 @@
 default: &default
   source_path: app/javascript
 
+  # Hook to run before compilation (e.g., for ReScript builds, pack generation)
+  # See: https://github.com/shakacode/shakapacker/blob/main/docs/precompile_hook.md
+  precompile_hook: bin/shakapacker-precompile-hook
+
   # You can have a subdirectory of the source_path, like 'packs' (recommended).
   # Alternatively, you can use '/' to use the whole source_path directory.
   # Notice that this is a relative path to source_path

lib/react_on_rails/dev/pack_generator.rb

@@ -25,15 +25,23 @@ def generate(verbose: false)
         private
 
         def run_pack_generation(silent: false)
-          # If we're already inside a Bundler context (e.g., called from bin/dev),
+          # If we're already inside a Bundler context AND Rails is available (e.g., called from bin/dev),
           # we can directly require and run the task. Otherwise, use bundle exec.
-          if defined?(Bundler)
+          if defined?(Bundler) && rails_available?
             run_rake_task_directly(silent: silent)
           else
             run_via_bundle_exec(silent: silent)
           end
         end
 
+        def rails_available?
+          return false unless defined?(Rails)
+          return false unless Rails.respond_to?(:application)
+          return false if Rails.application.nil?
+
+          true
+        end
+
         def run_rake_task_directly(silent: false)
           require "rake"
 

lib/react_on_rails/dev/server_manager.rb

@@ -416,34 +416,18 @@ def run_static_development(procfile, verbose: false, route: nil)
             route: route
           )
 
-          build_rescript_if_needed
           PackGenerator.generate(verbose: verbose)
           ProcessManager.ensure_procfile(procfile)
           ProcessManager.run_with_process_manager(procfile)
         end
 
         def run_development(procfile, verbose: false, route: nil)
           print_procfile_info(procfile, route: route)
-          build_rescript_if_needed
           PackGenerator.generate(verbose: verbose)
           ProcessManager.ensure_procfile(procfile)
           ProcessManager.run_with_process_manager(procfile)
         end
 
-        def build_rescript_if_needed
-          # Check for both old (bsconfig.json) and new (rescript.json) config files
-          return unless File.exist?("bsconfig.json") || File.exist?("rescript.json")
-
-          print "🔧 Building ReScript... "
-          success = system("yarn build:rescript > /dev/null 2>&1")
-          puts success ? "✅" : "❌"
-
-          return if success
-
-          puts "❌ ReScript build failed"
-          exit 1
-        end
-
         def print_server_info(title, features, port = 3000, route: nil)
           puts title
           features.each { |feature| puts "   - #{feature}" }

spec/dummy/bin/shakapacker-precompile-hook

@@ -0,0 +1,70 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+# Shakapacker precompile hook
+# This script runs before Shakapacker compilation in both development and production.
+# See: https://github.com/shakacode/shakapacker/blob/main/docs/precompile_hook.md
+
+require "fileutils"
+
+# Build ReScript if needed
+def build_rescript_if_needed
+  # Check for both old (bsconfig.json) and new (rescript.json) config files
+  return unless File.exist?("bsconfig.json") || File.exist?("rescript.json")
+
+  puts "🔧 Building ReScript..."
+
+  # Try to find the ReScript build command
+  if system("command -v yarn > /dev/null 2>&1")
+    success = system("yarn build:rescript")
+  elsif system("command -v npm > /dev/null 2>&1")
+    success = system("npm run build:rescript")
+  else
+    warn "⚠️  Warning: Neither yarn nor npm found. Skipping ReScript build."
+    return
+  end
+
+  if success
+    puts "✅ ReScript build completed successfully"
+  else
+    warn "❌ ReScript build failed"
+    exit 1
+  end
+end
+
+# Generate React on Rails packs if needed
+def generate_packs_if_needed
+  return unless File.exist?("config/initializers/react_on_rails.rb")
+
+  # Check if auto-pack generation is configured
+  config_file = File.read("config/initializers/react_on_rails.rb")
+  return unless config_file.include?("auto_load_bundle") || config_file.include?("components_subdirectory")
+
+  puts "📦 Generating React on Rails packs..."
+
+  # Check if bundle and rake task are available
+  bundle_available = system("command -v bundle > /dev/null 2>&1")
+  rake_task_exists = system("bundle exec rails -T | grep -q react_on_rails:generate_packs")
+  return unless bundle_available && rake_task_exists
+
+  success = system("bundle exec rails react_on_rails:generate_packs")
+
+  if success
+    puts "✅ Pack generation completed successfully"
+  else
+    warn "❌ Pack generation failed"
+    exit 1
+  end
+end
+
+# Main execution
+begin
+  build_rescript_if_needed
+  generate_packs_if_needed
+
+  exit 0
+rescue StandardError => e
+  warn "❌ Precompile hook failed: #{e.message}"
+  warn e.backtrace.join("\n")
+  exit 1
+end

spec/dummy/config/shakapacker.yml

@@ -5,6 +5,10 @@ default: &default
   source_entry_path: packs
   public_root_path: public
 
+  # Hook to run before compilation (e.g., for ReScript builds, pack generation)
+  # See: https://github.com/shakacode/shakapacker/blob/main/docs/precompile_hook.md
+  precompile_hook: bin/shakapacker-precompile-hook
+
   cache_path: tmp/cache/shakapacker
   webpack_compile_output: false
   ensure_consistent_versioning: true