Skip to content

Commit c4f738b

Browse files
alexeyrJudahmeek
authored andcommitted
Fix knip issues
1 parent bcb84ac commit c4f738b

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

.github/workflows/playwright.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,11 @@ jobs:
7878

7979
- name: Build test assets
8080
working-directory: spec/dummy
81-
run: yarn build:test
81+
run: yarn run build:test
8282

8383
- name: Run Playwright tests
8484
working-directory: spec/dummy
85-
run: yarn test:e2e
85+
run: yarn run test:e2e
8686

8787
- uses: actions/upload-artifact@v4
8888
if: always()

knip.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ const config: KnipConfig = {
7070
entry: [
7171
'src/ReactOnRailsProNodeRenderer.ts!',
7272
'src/default-node-renderer.ts!',
73-
'src/master.ts!',
74-
'src/worker.ts!',
73+
'src/integrations/*.ts!',
7574
],
7675
project: ['src/**/*.[jt]s{x,}!', 'tests/**/*.[jt]s{x,}', '!lib/**'],
7776
ignore: [
@@ -87,8 +86,9 @@ const config: KnipConfig = {
8786
// These are runtime dependencies needed for the package to work
8887
// even though they may not be directly imported in the source
8988
'react-on-rails-pro',
90-
// Dev dependencies used only in tests
89+
// Optional dependencies used in integrations
9190
'@honeybadger-io/js',
91+
'@sentry/*',
9292
],
9393
},
9494

@@ -204,6 +204,7 @@ const config: KnipConfig = {
204204
],
205205
},
206206
},
207+
ignoreExportsUsedInFile: true,
207208
};
208209

209210
export default config;

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"@babel/preset-react": "^7.26.3",
2121
"@babel/preset-typescript": "^7.27.1",
2222
"@eslint/compat": "^1.2.7",
23+
"@jest/globals": "^29.7.0",
2324
"@swc/core": "^1.15.0",
2425
"@testing-library/dom": "^10.4.0",
2526
"@testing-library/jest-dom": "^6.6.3",

packages/react-on-rails-pro-node-renderer/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"node-html-parser": "^7.0.1",
3838
"nps": "^5.9.12",
3939
"pino-pretty": "^13.0.0",
40+
"react-on-rails": "16.2.0-beta.11",
4041
"redis": "^5.0.1",
4142
"sentry-testkit": "^5.0.6",
4243
"touch": "^3.1.0",

packages/react-on-rails-pro-node-renderer/src/integrations/api.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ export {
3030
addNotifier,
3131
error,
3232
message,
33+
Notifier,
34+
ErrorNotifier,
35+
MessageNotifier,
3336
} from '../shared/errorReporter.js';
3437
export {
3538
setupTracing,

0 commit comments

Comments
 (0)