Skip to content

Commit c6c3f68

Browse files
justin808claude
andcommitted
Remove deprecated chromedriver-helper from dev_tests generator
chromedriver-helper was deprecated in March 2019 and is incompatible with modern selenium-webdriver (4.x). The gem tries to set Selenium::WebDriver::Chrome.driver_path which no longer exists. Modern selenium-webdriver uses webdriver-manager internally for driver management. GitHub Actions and most CI environments have Chrome and ChromeDriver pre-installed, so no driver helper gem is needed. This fixes the minimum version example tests which were failing with: "undefined method `driver_path=' for Selenium::WebDriver::Chrome:Module" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 8021316 commit c6c3f68

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

react_on_rails/lib/generators/react_on_rails/dev_tests_generator.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ def copy_tests
3131

3232
def add_test_related_gems_to_gemfile
3333
gem("rspec-rails", group: :test)
34-
gem("chromedriver-helper", group: :test)
34+
# NOTE: chromedriver-helper was deprecated in 2019. Modern selenium-webdriver (4.x)
35+
# and GitHub Actions have built-in driver management, so no driver helper is needed.
3536
gem("coveralls", require: false)
3637
end
3738

react_on_rails/spec/react_on_rails/generators/dev_tests_generator_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
assert_file("Gemfile") do |contents|
3535
expect(contents).to match("gem \"rspec-rails\", group: :test")
3636
expect(contents).to match("gem \"coveralls\", require: false")
37-
expect(contents).to match("gem \"chromedriver-helper\", group: :test")
37+
# chromedriver-helper was removed as it's deprecated since 2019
38+
# Modern selenium-webdriver (4.x) handles driver management automatically
3839
end
3940
end
4041
end

0 commit comments

Comments
 (0)