Restore version checking methods and add AUTO_BUNDLING constant

- Add caching to shakapacker_version_requirement_met? for performance
- Add supports_basic_pack_generation? and supports_autobundling? methods
- Add MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING constant
- Restore raise_shakapacker_version_incompatible_for_autobundling method
- Add raise_shakapacker_version_incompatible_for_basic_pack_generation method
- Update error messages to reference correct constants and include guidance
- Make generated_assets_dirs configuration throw exception instead of deprecation

BREAKING CHANGE: The `config.generated_assets_dirs` configuration option
is no longer supported since Shakapacker is now required.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

CHANGELOG.md

@@ -23,6 +23,10 @@ After a release, please make sure to run `bundle exec rake update_changelog`. Th
 
 Changes since the last non-beta release.
 
+#### Breaking Changes
+
+- **Removed `generated_assets_dirs` configuration**: The legacy `config.generated_assets_dirs` option is no longer supported and will raise an error if used. Since Shakapacker is now required, asset paths are automatically determined from `shakapacker.yml` configuration. Remove any `config.generated_assets_dirs` from your `config/initializers/react_on_rails.rb` file. Use `public_output_path` in `config/shakapacker.yml` to customize asset output location instead. [PR 1798](https://github.com/shakacode/react_on_rails/pull/1798)
+
 #### New Features
 
 - **Server Bundle Security**: Added new configuration options for enhanced server bundle security and organization:

lib/react_on_rails/configuration.rb

@@ -306,20 +306,20 @@ def ensure_generated_assets_dir_present
     def configure_generated_assets_dirs_deprecation
       return if generated_assets_dirs.blank?
 
-      # With Shakapacker always available:
       packer_public_output_path = ReactOnRails::PackerUtils.packer_public_output_path
-      # rubocop:disable Layout/LineLength
-      Rails.logger.warn "Error configuring config/initializers/react_on_rails. Define neither the generated_assets_dirs nor " \
-                        "the generated_assets_dir when using Shakapacker. This is defined by " \
-                        "public_output_path specified in shakapacker.yml = #{packer_public_output_path}."
-      # rubocop:enable Layout/LineLength
-      if generated_assets_dir.blank?
-        self.generated_assets_dir = generated_assets_dirs
-      else
-        Rails.logger.warn "[DEPRECATION] ReactOnRails. You have both generated_assets_dirs and " \
-                          "generated_assets_dir defined. Define ONLY generated_assets_dir if NOT using Shakapacker " \
-                          "and define neither if using Webpacker"
-      end
+
+      msg = <<~MSG
+        ReactOnRails Configuration Error: The 'generated_assets_dirs' configuration option is no longer supported.
+
+        Since Shakapacker is now required, asset paths are automatically determined from your shakapacker.yml configuration.
+
+        Please remove 'config.generated_assets_dirs' from your config/initializers/react_on_rails.rb file.
+        Assets will be loaded from: #{packer_public_output_path}
+
+        If you need to customize the output path, configure it in config/shakapacker.yml under 'public_output_path'.
+      MSG
+
+      raise ReactOnRails::Error, msg
     end
 
     def ensure_webpack_generated_files_exists

lib/react_on_rails/packer_utils.rb

@@ -26,15 +26,21 @@ def self.shakapacker_version_as_array
     end
 
     def self.shakapacker_version_requirement_met?(required_version)
-      Gem::Version.new(shakapacker_version) >= Gem::Version.new(required_version)
+      @version_checks ||= {}
+      @version_checks[required_version] ||= Gem::Version.new(shakapacker_version) >= Gem::Version.new(required_version)
     end
 
-    def self.supports_autobundling?
+    def self.supports_async_loading?
+      shakapacker_version_requirement_met?("8.2.0")
+    end
+
+    def self.supports_basic_pack_generation?
       shakapacker_version_requirement_met?(ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION)
     end
 
-    def self.supports_async_loading?
-      shakapacker_version_requirement_met?("8.2.0")
+    def self.supports_autobundling?
+      min_version = ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING
+      ::Shakapacker.config.respond_to?(:nested_entries?) && shakapacker_version_requirement_met?(min_version)
     end
 
     # This returns either a URL for the webpack-dev-server, non-server bundle or
@@ -137,9 +143,19 @@ def self.raise_nested_entries_disabled
 
     def self.raise_shakapacker_version_incompatible_for_autobundling
       msg = <<~MSG
-        **ERROR** ReactOnRails: Please upgrade Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or \
-        above to use the automated bundle generation feature. The currently installed version is \
-        #{ReactOnRails::PackerUtils.shakapacker_version}.
+        **ERROR** ReactOnRails: Please upgrade ::Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING} or \
+        above to use the automated bundle generation feature (which requires nested_entries support). \
+        The currently installed version is #{ReactOnRails::PackerUtils.shakapacker_version}. \
+        Basic pack generation requires ::Shakapacker #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or above.
+      MSG
+
+      raise ReactOnRails::Error, msg
+    end
+
+    def self.raise_shakapacker_version_incompatible_for_basic_pack_generation
+      msg = <<~MSG
+        **ERROR** ReactOnRails: Please upgrade ::Shakapacker to version #{ReactOnRails::PacksGenerator::MINIMUM_SHAKAPACKER_VERSION} or \
+        above to use basic pack generation features. The currently installed version is #{ReactOnRails::PackerUtils.shakapacker_version}.
       MSG
 
       raise ReactOnRails::Error, msg

lib/react_on_rails/packs_generator.rb

@@ -9,6 +9,7 @@ class PacksGenerator
     CONTAINS_CLIENT_OR_SERVER_REGEX = /\.(server|client)($|\.)/
     COMPONENT_EXTENSIONS = /\.(jsx?|tsx?)$/
     MINIMUM_SHAKAPACKER_VERSION = "6.5.1"
+    MINIMUM_SHAKAPACKER_VERSION_FOR_AUTO_BUNDLING = "7.0.0"
 
     def self.instance
       @instance ||= PacksGenerator.new