Commit d4985b5
Use default loading strategy based on Shakapacker version
The previous fix explicitly set generated_component_packs_loading_strategy
to :async, which broke CI for minimum dependencies (Shakapacker 6.0).
Root cause:
- Commit ee80bc2 changed main bundle to use async: true
- Original config had :defer explicitly set, causing race condition
- Setting :async explicitly breaks Shakapacker < 8.2.0
Solution:
- Remove explicit configuration setting
- Let it default based on Shakapacker version:
- Shakapacker >= 8.2.0: defaults to :async (optimal)
- Shakapacker < 8.2.0: defaults to :sync (compatible)
- Update test to check for version-appropriate default
This fixes both the original race condition AND maintains compatibility
with minimum supported dependencies.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent be61ade commit d4985b5
File tree
2 files changed
+11
-2
lines changed- spec/dummy
- config/initializers
- spec/helpers
2 files changed
+11
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
46 | 48 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
81 | 88 | | |
82 | 89 | | |
83 | 90 | | |
| |||
0 commit comments