Skip to content

Commit d5151db

Browse files
justin808claude
andcommitted
Fix Pro workflow paths after Phase 6 restructuring
After the Phase 6 restructuring, Pro Ruby gem code moved from: - react_on_rails_pro/lib/react_on_rails_pro/ → lib/react_on_rails_pro/ - react_on_rails_pro/spec/react_on_rails_pro/ → spec/pro/react_on_rails_pro/ But workflows still had working-directory: react_on_rails_pro which was causing failures because: 1. RSpec tests tried to run spec/react_on_rails_pro which doesn't exist in that directory anymore 2. Bundle install was looking in wrong vendor/bundle path 3. RuboCop was running in wrong directory Changes: - Update rspec-gem-specs job to run from root directory - Fix spec path from spec/react_on_rails_pro to spec/pro/react_on_rails_pro - Fix cache paths from react_on_rails_pro/vendor/bundle to vendor/bundle - Fix log path from react_on_rails_pro/log/test.log to log/test.log - Update RuboCop to explicitly lint lib/react_on_rails_pro and spec/pro - Add working-directory: . to Ruby gem operations that need root context Fixes https://github.com/shakacode/react_on_rails/actions/runs/19607357889/job/56148089097 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent b42600f commit d5151db

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

.github/workflows/pro-lint.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ jobs:
118118
- name: Cache Pro package Ruby gems
119119
uses: actions/cache@v4
120120
with:
121-
path: react_on_rails_pro/vendor/bundle
121+
path: vendor/bundle
122122
key: v4-pro-package-gem-cache-${{ hashFiles('react_on_rails_pro.gemspec') }}
123123

124124
- name: Cache Pro dummy app node modules
@@ -134,6 +134,7 @@ jobs:
134134
key: v4-pro-dummy-app-gem-cache-${{ hashFiles('react_on_rails_pro/spec/dummy/Gemfile.lock') }}
135135

136136
- name: Install Ruby Gems for Pro package
137+
working-directory: .
137138
run: |
138139
gem install bundler -v "2.5.4"
139140
echo "Bundler version: "; bundle --version
@@ -166,9 +167,11 @@ jobs:
166167
run: yarn workspace react-on-rails-pro build
167168

168169
- name: Lint Ruby
169-
run: bundle exec rubocop --ignore-parent-exclusion
170+
working-directory: .
171+
run: bundle exec rubocop --ignore-parent-exclusion lib/react_on_rails_pro spec/pro
170172

171173
- name: Validate RBS type signatures
174+
working-directory: .
172175
run: bundle exec rake rbs:validate
173176

174177
- name: Lint JS

.github/workflows/pro-test-package-and-gem.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ jobs:
102102
cache-dependency-path: '**/yarn.lock'
103103

104104
- name: Print system information
105+
working-directory: .
105106
run: |
106107
echo "Linux release: "; cat /etc/issue
107108
echo "Current user: "; whoami
@@ -205,6 +206,7 @@ jobs:
205206
cache-dependency-path: '**/yarn.lock'
206207

207208
- name: Print system information
209+
working-directory: .
208210
run: |
209211
echo "Linux release: "; cat /etc/issue
210212
echo "Current user: "; whoami
@@ -284,6 +286,7 @@ jobs:
284286
bundler: 2.5.4
285287

286288
- name: Print system information
289+
working-directory: .
287290
run: |
288291
echo "Linux release: "; cat /etc/issue
289292
echo "Current user: "; whoami
@@ -294,10 +297,11 @@ jobs:
294297
- name: Cache Pro package Ruby gems
295298
uses: actions/cache@v4
296299
with:
297-
path: react_on_rails_pro/vendor/bundle
300+
path: vendor/bundle
298301
key: v4-pro-package-gem-cache-ruby${{ matrix.ruby-version }}-${{ hashFiles('react_on_rails_pro.gemspec') }}
299302

300303
- name: Install Ruby Gems for Pro package
304+
working-directory: .
301305
run: |
302306
gem install bundler -v "2.5.4"
303307
echo "Bundler version: "; bundle --version
@@ -306,7 +310,8 @@ jobs:
306310
bundle _2.5.4_ check || bundle _2.5.4_ install --jobs=4 --retry=3
307311
308312
- name: Run RSpec tests for Pro package
309-
run: bundle exec rspec spec/react_on_rails_pro
313+
working-directory: .
314+
run: bundle exec rspec spec/pro/react_on_rails_pro
310315

311316
- name: Store test results
312317
uses: actions/upload-artifact@v4
@@ -320,4 +325,4 @@ jobs:
320325
if: always()
321326
with:
322327
name: pro-rspec-package-log-ruby${{ matrix.ruby-version }}
323-
path: react_on_rails_pro/log/test.log
328+
path: log/test.log

0 commit comments

Comments
 (0)