Commit d584749
Remove unnecessary REACT_ON_RAILS_SKIP_VALIDATION from generator template
The SKIP_VALIDATION environment variable is not needed in the generator
template because:
1. By the time apps use this hook, packages are already installed
2. The engine's skip_version_validation? already handles edge cases:
- package_json_missing? check
- running_generator? check
3. This was cargo-culted from the Ruby version which needed it for
different reasons (loading Rails environment directly)
The shared implementation in spec/support still sets this variable
because test apps have different requirements, but user-generated
apps should rely on the engine's built-in validation logic.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 278c932 commit d584749
File tree
1 file changed
+0
-3
lines changed- lib/generators/react_on_rails/templates/base/base/bin
1 file changed
+0
-3
lines changedLines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | 11 | | |
15 | 12 | | |
16 | 13 | | |
| |||
0 commit comments