Skip to content

Commit d8c3230

Browse files
justin808claude
andcommitted
Fix matrix exclude keys in build-dummy-app-webpack-test-bundles job
Adds the missing exclude section to the build-dummy-app-webpack-test-bundles job to match the structure used in dummy-app-integration-tests job. This fixes the GitHub Actions error where matrix exclude keys (ruby-version, node-version, dependency-level) didn't match any keys within the matrix. The exclude section prevents the minimum dependency matrix (Ruby 3.2, Node 20) from running on regular PRs, ensuring it only runs on master, workflow_dispatch, force_run, or when the full-ci label is present. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 37f5894 commit d8c3230

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

.github/workflows/integration-tests.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,11 @@ jobs:
7373
- ruby-version: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && '3.2'}}
7474
node-version: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && '20'}}
7575
dependency-level: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && 'minimum'}}
76+
exclude:
77+
# Skip minimum dependency matrix on regular PRs (run only on master/workflow_dispatch/force_run/full-ci label)
78+
- ruby-version: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && inputs.force_run != true && needs.detect-changes.outputs.has_full_ci_label != 'true' && '3.2' || '' }}
79+
node-version: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && inputs.force_run != true && needs.detect-changes.outputs.has_full_ci_label != 'true' && '20' || '' }}
80+
dependency-level: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && inputs.force_run != true && needs.detect-changes.outputs.has_full_ci_label != 'true' && 'minimum' || '' }}
7681
runs-on: ubuntu-22.04
7782
steps:
7883
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)