ensure missing package and package without dependencies get same result

Author: Judahmeek

lib/react_on_rails/version_checker.rb

@@ -85,17 +85,17 @@ def initialize(package_json)
       end
 
       def raw
-        return nil unless File.exist?(package_json)
-
-        parsed_package_contents = JSON.parse(package_json_contents)
-        if parsed_package_contents.key?("dependencies") &&
-           parsed_package_contents["dependencies"].key?("react-on-rails")
-          parsed_package_contents["dependencies"]["react-on-rails"]
-        else
-          msg = "No 'react-on-rails' entry in the dependencies of #{NodePackageVersion.package_json_path}, " \
-                "which is the expected location according to ReactOnRails.configuration.node_modules_location"
-          Rails.logger.warn(msg)
+        if File.exist?(package_json)
+          parsed_package_contents = JSON.parse(package_json_contents)
+          if parsed_package_contents.key?("dependencies") &&
+             parsed_package_contents["dependencies"].key?("react-on-rails")
+            return parsed_package_contents["dependencies"]["react-on-rails"]
+          end
         end
+        msg = "No 'react-on-rails' entry in the dependencies of #{NodePackageVersion.package_json_path}, " \
+              "which is the expected location according to ReactOnRails.configuration.node_modules_location"
+        Rails.logger.warn(msg)
+        nil
       end
 
       def semver_wildcard?

spec/react_on_rails/version_checker_spec.rb

@@ -250,11 +250,27 @@ def check_version_and_log(node_package_version)
         end
       end
 
+      context "with package.json without react-on-rails dependency" do
+        let(:package_json) { File.expand_path("../../package.json", __dir__) }
+
+        describe "#raw" do
+          it "returns nil" do
+            root_package_json_path = File.expand_path("fixtures/nonexistent_package.json", __dir__)
+            allow(Rails).to receive_message_chain(:root, :join).and_return(root_package_json_path)
+            expect(node_package_version.raw).to be_nil
+          end
+        end
+      end
+
       context "with non-existing package.json" do
         let(:package_json) { File.expand_path("fixtures/nonexistent_package.json", __dir__) }
 
         describe "#raw" do
-          specify { expect(node_package_version.raw).to be_nil }
+          it "returns nil" do
+            root_package_json_path = File.expand_path("fixtures/nonexistent_package.json", __dir__)
+            allow(Rails).to receive_message_chain(:root, :join).and_return(root_package_json_path)
+            expect(node_package_version.raw).to be_nil
+          end
         end
       end
     end