Commit e133a13
Fix edge cases in version manager detection and improve UX
Based on additional code review feedback:
**Version Detection Improvements:**
- Use `rvm list rubies` instead of `rvm list strings` for more consistent
output across different rvm versions
- Use `nvm version VERSION` instead of `nvm list | grep` for more reliable
version checking across different nvm versions
**User Experience:**
- Add explicit warning that rvm/nvm version changes only affect the
script's subshell
- Inform users they may need to open a new terminal or source their
shell config for changes to take effect
- Clarify the persistent vs. temporary nature of version switches
These changes make the script more robust across different version
manager installations and set clearer expectations for users.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 3988a3a commit e133a13
1 file changed
+20
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
| 67 | + | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
128 | | - | |
| 127 | + | |
| 128 | + | |
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
290 | 298 | | |
291 | 299 | | |
292 | 300 | | |
| |||
395 | 403 | | |
396 | 404 | | |
397 | 405 | | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
398 | 414 | | |
399 | 415 | | |
400 | 416 | | |
| |||
0 commit comments