Phase 3: Move RSC utility methods to Pro gem

- Remove RSC utility methods from ReactOnRails::Utils:
  - rsc_bundle_js_file_path
  - react_client_manifest_file_path
  - react_server_client_manifest_file_path

- Add these methods to ReactOnRailsPro::Utils with same functionality

- Update rsc_support_enabled? in open-source to delegate to Pro gem

- Update all internal Pro gem references to use ReactOnRailsPro::Utils:
  - react_on_rails_pro/lib/react_on_rails_pro/request.rb
  - react_on_rails_pro/lib/react_on_rails_pro/utils.rb

- Update webpack_assets_status_checker.rb to call ReactOnRailsPro::Utils

- Remove RSC utility tests from open-source spec (lines 452-839)
  - Removed rsc_bundle_js_file_path tests
  - Removed react_client_manifest_file_path tests
  - Removed react_server_client_manifest_file_path tests

- Update Pro gem test mocks to reference ReactOnRailsPro::Utils:
  - react_on_rails_pro/spec/react_on_rails_pro/utils_spec.rb
  - react_on_rails_pro/spec/react_on_rails_pro/request_spec.rb

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: AbanoubGhadban

lib/react_on_rails/test_helper/webpack_assets_status_checker.rb

@@ -54,9 +54,9 @@ def all_compiled_assets
             if ReactOnRails::Utils.react_on_rails_pro?
               pro_config = ReactOnRailsPro.configuration
               if bundle_name == pro_config.react_client_manifest_file
-                ReactOnRails::Utils.react_client_manifest_file_path
+                ReactOnRailsPro::Utils.react_client_manifest_file_path
               elsif bundle_name == pro_config.react_server_client_manifest_file
-                ReactOnRails::Utils.react_server_client_manifest_file_path
+                ReactOnRailsPro::Utils.react_server_client_manifest_file_path
               else
                 ReactOnRails::Utils.bundle_js_file_path(bundle_name)
               end

lib/react_on_rails/utils.rb

@@ -153,34 +153,6 @@ def self.server_bundle_js_file_path
       @server_bundle_path = bundle_js_file_path(bundle_name)
     end
 
-    def self.rsc_bundle_js_file_path
-      return @rsc_bundle_path if @rsc_bundle_path && !Rails.env.development?
-
-      bundle_name = ReactOnRails.configuration.rsc_bundle_js_file
-      @rsc_bundle_path = bundle_js_file_path(bundle_name)
-    end
-
-    def self.react_client_manifest_file_path
-      return @react_client_manifest_path if @react_client_manifest_path && !Rails.env.development?
-
-      file_name = ReactOnRails.configuration.react_client_manifest_file
-      @react_client_manifest_path = ReactOnRails::PackerUtils.asset_uri_from_packer(file_name)
-    end
-
-    # React Server Manifest is generated by the server bundle.
-    # So, it will never be served from the dev server.
-    def self.react_server_client_manifest_file_path
-      return @react_server_manifest_path if @react_server_manifest_path && !Rails.env.development?
-
-      asset_name = ReactOnRails.configuration.react_server_client_manifest_file
-      if asset_name.nil?
-        raise ReactOnRails::Error,
-              "react_server_client_manifest_file is nil, ensure it is set in your configuration"
-      end
-
-      @react_server_manifest_path = bundle_js_file_path(asset_name)
-    end
-
     def self.running_on_windows?
       (/cygwin|mswin|mingw|bccwin|wince|emx/ =~ RUBY_PLATFORM) != nil
     end
@@ -261,13 +233,12 @@ def self.react_on_rails_pro_version
                                     end
     end
 
+    # RSC support detection has been moved to React on Rails Pro
+    # See react_on_rails_pro/lib/react_on_rails_pro/utils.rb
     def self.rsc_support_enabled?
       return false unless react_on_rails_pro?
 
-      return @rsc_support_enabled if defined?(@rsc_support_enabled)
-
-      rorp_config = ReactOnRailsPro.configuration
-      @rsc_support_enabled = rorp_config.respond_to?(:enable_rsc_support) && rorp_config.enable_rsc_support
+      ReactOnRailsPro::Utils.rsc_support_enabled?
     end
 
     def self.full_text_errors_enabled?

react_on_rails_pro/lib/react_on_rails_pro/request.rb

@@ -49,7 +49,7 @@ def upload_assets
 
         # Add RSC bundle if enabled
         if ReactOnRailsPro.configuration.enable_rsc_support
-          rsc_bundle_path = ReactOnRails::Utils.rsc_bundle_js_file_path
+          rsc_bundle_path = ReactOnRailsPro::Utils.rsc_bundle_js_file_path
           unless File.exist?(rsc_bundle_path)
             raise ReactOnRailsPro::Error, "RSC bundle not found at #{rsc_bundle_path}. " \
                                           "Please build your bundles before uploading assets."
@@ -154,7 +154,7 @@ def populate_form_with_bundle_and_assets(form, check_bundle:)
         if ReactOnRailsPro.configuration.enable_rsc_support
           add_bundle_to_form(
             form,
-            bundle_path: ReactOnRails::Utils.rsc_bundle_js_file_path,
+            bundle_path: ReactOnRailsPro::Utils.rsc_bundle_js_file_path,
             bundle_file_name: pool.rsc_renderer_bundle_file_name,
             bundle_hash: pool.rsc_bundle_hash,
             check_bundle: check_bundle
@@ -178,8 +178,8 @@ def add_assets_to_form(form)
         assets_to_copy = (ReactOnRailsPro.configuration.assets_to_copy || []).dup
         # react_client_manifest and react_server_manifest files are needed to generate react server components payload
         if ReactOnRailsPro.configuration.enable_rsc_support
-          assets_to_copy << ReactOnRails::Utils.react_client_manifest_file_path
-          assets_to_copy << ReactOnRails::Utils.react_server_client_manifest_file_path
+          assets_to_copy << ReactOnRailsPro::Utils.react_client_manifest_file_path
+          assets_to_copy << ReactOnRailsPro::Utils.react_server_client_manifest_file_path
         end
 
         return form unless assets_to_copy.present?

react_on_rails_pro/lib/react_on_rails_pro/utils.rb

@@ -16,6 +16,44 @@ def self.rorp_puts(message)
       puts "[ReactOnRailsPro] #{message}"
     end
 
+    # RSC Configuration Utility Methods
+    # These methods were moved from ReactOnRails::Utils as they are Pro-only features
+
+    def self.rsc_bundle_js_file_path
+      return @rsc_bundle_path if @rsc_bundle_path && !Rails.env.development?
+
+      bundle_name = ReactOnRailsPro.configuration.rsc_bundle_js_file
+      @rsc_bundle_path = ReactOnRails::Utils.bundle_js_file_path(bundle_name)
+    end
+
+    def self.react_client_manifest_file_path
+      return @react_client_manifest_path if @react_client_manifest_path && !Rails.env.development?
+
+      file_name = ReactOnRailsPro.configuration.react_client_manifest_file
+      @react_client_manifest_path = ReactOnRails::PackerUtils.asset_uri_from_packer(file_name)
+    end
+
+    # React Server Manifest is generated by the server bundle.
+    # So, it will never be served from the dev server.
+    def self.react_server_client_manifest_file_path
+      return @react_server_manifest_path if @react_server_manifest_path && !Rails.env.development?
+
+      asset_name = ReactOnRailsPro.configuration.react_server_client_manifest_file
+      if asset_name.nil?
+        raise ReactOnRailsPro::Error,
+              "react_server_client_manifest_file is nil, ensure it is set in your configuration"
+      end
+
+      @react_server_manifest_path = ReactOnRails::Utils.bundle_js_file_path(asset_name)
+    end
+
+    def self.rsc_support_enabled?
+      return @rsc_support_enabled if defined?(@rsc_support_enabled)
+
+      rorp_config = ReactOnRailsPro.configuration
+      @rsc_support_enabled = rorp_config.respond_to?(:enable_rsc_support) && rorp_config.enable_rsc_support
+    end
+
     # Validates the license and raises an exception if invalid.
     #
     # @return [Boolean] true if license is valid
@@ -66,7 +104,7 @@ def self.bundle_hash
     def self.rsc_bundle_hash
       return @rsc_bundle_hash if @rsc_bundle_hash && !(Rails.env.development? || Rails.env.test?)
 
-      server_rsc_bundle_js_file_path = ReactOnRails::Utils.rsc_bundle_js_file_path
+      server_rsc_bundle_js_file_path = rsc_bundle_js_file_path
 
       return @rsc_bundle_hash if @rsc_bundle_hash && bundle_mtime_same?(server_rsc_bundle_js_file_path)
 
@@ -114,7 +152,7 @@ def self.bundle_mtime_same?(server_bundle_js_file_path)
     def self.contains_hash?(server_bundle_basename)
       # TODO: Need to consider if the configuration value has the ".js" on the end.
       ReactOnRails.configuration.server_bundle_js_file != server_bundle_basename &&
-        ReactOnRails.configuration.rsc_bundle_js_file != server_bundle_basename
+        ReactOnRailsPro.configuration.rsc_bundle_js_file != server_bundle_basename
     end
 
     def self.with_trace(message = nil)

react_on_rails_pro/spec/react_on_rails_pro/request_spec.rb

@@ -21,22 +21,20 @@
     File.write(rsc_server_bundle_path, 'console.log("mock RSC bundle");')
 
     clear_stream_mocks
-    allow(ReactOnRailsPro.configuration).to receive(:renderer_url).and_return(renderer_url)
-    allow(ReactOnRailsPro.configuration).to receive(:renderer_http_pool_size).and_return(20)
+    allow(ReactOnRailsPro.configuration).to receive_messages(renderer_url: renderer_url, renderer_http_pool_size: 20)
 
     original_httpx_plugin = HTTPX.method(:plugin)
     allow(HTTPX).to receive(:plugin) do |*args|
       original_httpx_plugin.call(:mock_stream).plugin(*args)
     end
     allow(Rails).to receive(:logger).and_return(logger_mock)
 
-    allow(ReactOnRailsPro::ServerRenderingPool::NodeRenderingPool).to receive(:renderer_bundle_file_name)
-      .and_return(renderer_bundle_file_name)
-    allow(ReactOnRailsPro::ServerRenderingPool::NodeRenderingPool).to receive(:rsc_renderer_bundle_file_name)
-      .and_return(rsc_renderer_bundle_file_name)
+    allow(ReactOnRailsPro::ServerRenderingPool::NodeRenderingPool).to receive_messages(
+      renderer_bundle_file_name: renderer_bundle_file_name, rsc_renderer_bundle_file_name: rsc_renderer_bundle_file_name
+    )
     allow(ReactOnRails::Utils).to receive(:server_bundle_js_file_path).and_return(server_bundle_path)
 
-    allow(ReactOnRails::Utils).to receive(:rsc_bundle_js_file_path).and_return(rsc_server_bundle_path)
+    allow(ReactOnRailsPro::Utils).to receive(:rsc_bundle_js_file_path).and_return(rsc_server_bundle_path)
   end
 
   after do

react_on_rails_pro/spec/react_on_rails_pro/utils_spec.rb

@@ -78,13 +78,16 @@ module ReactOnRailsPro
               rsc_bundle_js_file_path = File.expand_path("./public/#{rsc_bundle_js_file}")
               allow(Shakapacker).to receive_message_chain("manifest.lookup!")
                 .and_return(rsc_bundle_js_file)
-              allow(ReactOnRails::Utils).to receive_messages(
-                server_bundle_js_file_path: rsc_bundle_js_file_path.gsub("rsc-", ""),
-                rsc_bundle_js_file_path: rsc_bundle_js_file_path
-              )
+              allow(ReactOnRails::Utils).to receive(:server_bundle_js_file_path)
+                .and_return(rsc_bundle_js_file_path.gsub("rsc-", ""))
+              allow(described_class).to receive(:rsc_bundle_js_file_path)
+                .and_return(rsc_bundle_js_file_path)
               allow(ReactOnRails.configuration)
-                .to receive_messages(server_bundle_js_file: "webpack-bundle.js",
-                                     rsc_bundle_js_file: "rsc-webpack-bundle.js")
+                .to receive(:server_bundle_js_file)
+                .and_return("webpack-bundle.js")
+              allow(ReactOnRailsPro.configuration)
+                .to receive(:rsc_bundle_js_file)
+                .and_return("rsc-webpack-bundle.js")
               allow(Digest::MD5).to receive(:file)
                 .with(rsc_bundle_js_file_path)
                 .and_return("barfoobarfoo")