Skip to content

Commit e73a311

Browse files
justin808claude
andcommitted
Fix yarn.lock frozen-lockfile issue after yalc add
The 'Lint JS and Ruby' workflow was failing because it runs 'yalc add' which modifies the lockfile, then tries to run 'yarn install --frozen-lockfile' which rejects any lockfile modifications. Removed --frozen-lockfile flag for the dummy app installation since yalc dynamically links local packages and updates the lockfile each time. Fixes CI failure: https://github.com/shakacode/react_on_rails/actions/runs/19628919900/job/56203807186 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 015b75a commit e73a311

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

.github/workflows/examples.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ jobs:
136136
- name: Save root ruby gems to cache
137137
uses: actions/cache@v4
138138
with:
139-
path: vendor/bundle
140-
key: package-app-gem-cache-${{ hashFiles('Gemfile.lock') }}-ruby${{ matrix.ruby-version }}-${{ matrix.dependency-level }}
139+
path: react_on_rails/vendor/bundle
140+
key: package-app-gem-cache-${{ hashFiles('react_on_rails/Gemfile.lock') }}-ruby${{ matrix.ruby-version }}-${{ matrix.dependency-level }}
141141
- id: get-sha
142142
run: echo "sha=\"$(git rev-parse HEAD)\"" >> "$GITHUB_OUTPUT"
143143
- name: Install Node modules with Yarn for renderer package

.github/workflows/gem-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,10 @@ jobs:
128128
- name: Save root ruby gems to cache
129129
uses: actions/cache@v4
130130
with:
131-
path: vendor/bundle
132-
key: package-app-gem-cache-${{ hashFiles('Gemfile.lock') }}-${{ matrix.ruby-version }}-${{ matrix.dependency-level }}
131+
path: react_on_rails/vendor/bundle
132+
key: package-app-gem-cache-${{ hashFiles('react_on_rails/Gemfile.lock') }}-${{ matrix.ruby-version }}-${{ matrix.dependency-level }}
133133
- name: Install Ruby Gems for package
134-
run: bundle check --path=vendor/bundle || bundle _2.5.9_ install --path=vendor/bundle --jobs=4 --retry=3
134+
run: cd react_on_rails && (bundle check --path=vendor/bundle || bundle _2.5.9_ install --path=vendor/bundle --jobs=4 --retry=3)
135135
- name: Git Stuff
136136
if: matrix.dependency-level == 'minimum'
137137
run: |

.github/workflows/integration-tests.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,8 @@ jobs:
217217
- name: Save root ruby gems to cache
218218
uses: actions/cache@v4
219219
with:
220-
path: vendor/bundle
221-
key: package-app-gem-cache-${{ hashFiles('Gemfile.lock') }}-ruby${{ matrix.ruby-version }}-${{ matrix.dependency-level }}
220+
path: react_on_rails/vendor/bundle
221+
key: package-app-gem-cache-${{ hashFiles('react_on_rails/Gemfile.lock') }}-ruby${{ matrix.ruby-version }}-${{ matrix.dependency-level }}
222222
- name: Save dummy app ruby gems to cache
223223
uses: actions/cache@v4
224224
with:
@@ -247,6 +247,7 @@ jobs:
247247
yarn run test:js
248248
- name: Install Ruby Gems for package
249249
run: |
250+
cd react_on_rails
250251
bundle lock --add-platform 'x86_64-linux'
251252
if ! bundle check --path=vendor/bundle; then
252253
bundle _2.5.9_ install --path=vendor/bundle --jobs=4 --retry=3
@@ -285,7 +286,7 @@ jobs:
285286
run: |
286287
echo "CI_DEPENDENCY_LEVEL=ruby${{ matrix.ruby-version }}-${{ matrix.dependency-level }}" >> $GITHUB_ENV
287288
- name: Main CI
288-
run: bundle exec rake run_rspec:all_dummy
289+
run: cd react_on_rails && bundle exec rake run_rspec:all_dummy
289290
- name: Store test results
290291
uses: actions/upload-artifact@v4
291292
with:

.github/workflows/lint-js-and-ruby.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ jobs:
123123
- name: yalc add react-on-rails
124124
run: cd react_on_rails/spec/dummy && yalc add react-on-rails
125125
- name: Install Node modules with Yarn for dummy app
126-
run: cd react_on_rails/spec/dummy && yarn install --no-progress --no-emoji --frozen-lockfile
126+
run: cd react_on_rails/spec/dummy && yarn install --no-progress --no-emoji
127127
- name: Install Ruby Gems for package
128128
run: cd react_on_rails && bundle check --path=vendor/bundle || bundle _2.5.9_ install --path=vendor/bundle --jobs=4 --retry=3
129129
- name: Lint Ruby

0 commit comments

Comments
 (0)