Test handleRequestClosed is called when connection closes

Add verification that the handleRequestClosed sink method is properly
called when HTTP connections close in incremental render tests.

Changes:
- Update createMockSink() to return handleRequestClosed mock
- Update createBasicTestSetup() and createStreamingTestSetup() helpers
- Add handleRequestClosed verification to 5 tests
- Use waitFor() to handle async cleanup timing

All 11 tests pass, confirming handleRequestClosed is called once per
connection close across both mocked and streaming scenarios.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: AbanoubGhadban

react_on_rails_pro/packages/node-renderer/tests/incrementalRender.test.ts

@@ -67,12 +67,14 @@ describe('incremental render NDJSON endpoint', () => {
 
   const createMockSink = () => {
     const sinkAdd = jest.fn();
+    const handleRequestClosed = jest.fn();
 
     const sink: incremental.IncrementalRenderSink = {
       add: sinkAdd,
+      handleRequestClosed,
     };
 
-    return { sink, sinkAdd };
+    return { sink, sinkAdd, handleRequestClosed };
   };
 
   const createMockResponse = (data = 'mock response'): ResponseResult => ({
@@ -124,7 +126,7 @@ describe('incremental render NDJSON endpoint', () => {
   const createBasicTestSetup = async () => {
     await createVmBundle(TEST_NAME);
 
-    const { sink, sinkAdd } = createMockSink();
+    const { sink, sinkAdd, handleRequestClosed } = createMockSink();
     const mockResponse = createMockResponse();
     const mockResult = createMockResult(sink, mockResponse);
 
@@ -137,6 +139,7 @@ describe('incremental render NDJSON endpoint', () => {
     return {
       sink,
       sinkAdd,
+      handleRequestClosed,
       mockResponse,
       mockResult,
       handleSpy,
@@ -158,9 +161,11 @@ describe('incremental render NDJSON endpoint', () => {
     });
 
     const sinkAdd = jest.fn();
+    const handleRequestClosed = jest.fn();
 
     const sink: incremental.IncrementalRenderSink = {
       add: sinkAdd,
+      handleRequestClosed,
     };
 
     const mockResponse: ResponseResult = {
@@ -183,6 +188,7 @@ describe('incremental render NDJSON endpoint', () => {
     return {
       responseStream,
       sinkAdd,
+      handleRequestClosed,
       sink,
       mockResponse,
       mockResult,
@@ -256,7 +262,7 @@ describe('incremental render NDJSON endpoint', () => {
   });
 
   test('calls handleIncrementalRenderRequest immediately after first chunk and processes each subsequent chunk immediately', async () => {
-    const { sinkAdd, handleSpy, SERVER_BUNDLE_TIMESTAMP } = await createBasicTestSetup();
+    const { sinkAdd, handleRequestClosed, handleSpy, SERVER_BUNDLE_TIMESTAMP } = await createBasicTestSetup();
 
     // Create the HTTP request
     const req = createHttpRequest(SERVER_BUNDLE_TIMESTAMP);
@@ -304,6 +310,11 @@ describe('incremental render NDJSON endpoint', () => {
     // Final verification: all chunks were processed in the correct order
     expect(handleSpy).toHaveBeenCalledTimes(1);
     expect(sinkAdd.mock.calls).toEqual([[{ a: 1 }], [{ b: 2 }], [{ c: 3 }]]);
+
+    // Verify handleRequestClosed was called when connection closed
+    await waitFor(() => {
+      expect(handleRequestClosed).toHaveBeenCalledTimes(1);
+    });
   });
 
   test('returns 410 error when bundle is missing', async () => {
@@ -357,7 +368,7 @@ describe('incremental render NDJSON endpoint', () => {
     // Create a bundle for this test
     await createVmBundle(TEST_NAME);
 
-    const { sink, sinkAdd } = createMockSink();
+    const { sink, sinkAdd, handleRequestClosed } = createMockSink();
 
     const mockResponse: ResponseResult = createMockResponse();
 
@@ -416,13 +427,16 @@ describe('incremental render NDJSON endpoint', () => {
     await waitFor(() => {
       expect(sinkAdd.mock.calls).toEqual([[{ a: 1 }], [{ d: 4 }]]);
     });
+
+    // Verify handleRequestClosed was called when connection closed
+    expect(handleRequestClosed).toHaveBeenCalledTimes(1);
   });
 
   test('handles empty lines gracefully in the stream', async () => {
     // Create a bundle for this test
     await createVmBundle(TEST_NAME);
 
-    const { sink, sinkAdd } = createMockSink();
+    const { sink, sinkAdd, handleRequestClosed } = createMockSink();
 
     const mockResponse: ResponseResult = createMockResponse();
 
@@ -469,6 +483,11 @@ describe('incremental render NDJSON endpoint', () => {
     // Verify that only valid JSON objects were processed
     expect(handleSpy).toHaveBeenCalledTimes(1);
     expect(sinkAdd.mock.calls).toEqual([[{ a: 1 }], [{ b: 2 }], [{ c: 3 }]]);
+
+    // Verify handleRequestClosed was called when connection closed
+    await waitFor(() => {
+      expect(handleRequestClosed).toHaveBeenCalledTimes(1);
+    });
   });
 
   test('throws error when first chunk processing fails (e.g., authentication)', async () => {
@@ -515,7 +534,8 @@ describe('incremental render NDJSON endpoint', () => {
       'Goodbye from stream',
     ];
 
-    const { responseStream, sinkAdd, handleSpy, SERVER_BUNDLE_TIMESTAMP } = await createStreamingTestSetup();
+    const { responseStream, sinkAdd, handleRequestClosed, handleSpy, SERVER_BUNDLE_TIMESTAMP } =
+      await createStreamingTestSetup();
 
     // write the response chunks to the stream
     let sentChunkIndex = 0;
@@ -586,10 +606,14 @@ describe('incremental render NDJSON endpoint', () => {
 
     // Verify that the mock was called correctly
     expect(handleSpy).toHaveBeenCalledTimes(1);
+
+    // Verify handleRequestClosed was called when connection closed
+    expect(handleRequestClosed).toHaveBeenCalledTimes(1);
   });
 
   test('echo server - processes each chunk and immediately streams it back', async () => {
-    const { responseStream, sinkAdd, handleSpy, SERVER_BUNDLE_TIMESTAMP } = await createStreamingTestSetup();
+    const { responseStream, sinkAdd, handleRequestClosed, handleSpy, SERVER_BUNDLE_TIMESTAMP } =
+      await createStreamingTestSetup();
 
     // Create the HTTP request
     const req = createHttpRequest(SERVER_BUNDLE_TIMESTAMP);
@@ -677,6 +701,9 @@ describe('incremental render NDJSON endpoint', () => {
 
     // Verify that the mock was called correctly
     expect(handleSpy).toHaveBeenCalledTimes(1);
+
+    // Verify handleRequestClosed was called when connection closed
+    expect(handleRequestClosed).toHaveBeenCalledTimes(1);
   });
 
   describe('incremental render update chunk functionality', () => {