Commit edd0463
Fix CI failures on master (#1940)
## Summary
This PR fixes the CI failures on master that were introduced by PR #1934
(smart error messages).
### Changes Made
**ESLint Fixes:**
- Fixed `@typescript-eslint/no-deprecated` error in
`ClientSideRenderer.ts` by adding eslint-disable comment for
`unmountComponentAtNode` (React 18 deprecated API that we still need to
support for older versions)
- Fixed `@typescript-eslint/unbound-method` errors in
`createReactOnRailsPro.ts` by adding eslint-disable comments for method
references
**Test Fixes:**
- Updated test expectation in `react_on_rails_helper_spec.rb` to expect
`ReactOnRails::SmartError` instead of `ReactOnRails::Error`
- Updated error message regex from `/the generated component
entrypoint/` to `/Auto-loaded Bundle Missing/` to match the new
SmartError format
### Test Plan
- ✅ All linting passes locally (`bundle exec rubocop` and `yarn run
lint`)
- ✅ Specific failing test now passes
(`spec/helpers/react_on_rails_helper_spec.rb:128`)
- ✅ Pre-commit hooks pass
### Notes
- `SmartError` is a subclass of `Error`, so this change maintains
backward compatibility
- The new error messages are more user-friendly and actionable
- All changes align with the smart error messages introduced in PR #1934
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/shakacode/react_on_rails/1940)
<!-- Reviewable:end -->
Co-authored-by: Claude <[email protected]>1 parent 57fb6bf commit edd0463
File tree
3 files changed
+4
-1
lines changed- packages/react-on-rails-pro/src
- spec/dummy/spec/helpers
3 files changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| 191 | + | |
191 | 192 | | |
192 | 193 | | |
193 | 194 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| 148 | + | |
148 | 149 | | |
149 | 150 | | |
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
| 154 | + | |
153 | 155 | | |
154 | 156 | | |
155 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
0 commit comments