Skip to content

Commit eed0dfa

Browse files
justin808claude
andcommitted
Fix dummy app tests: skip version validation in monorepo context
The dummy app integration tests were failing with: "ERROR ReactOnRails: You have the Pro gem installed but are using the base 'react-on-rails' package" This occurred because: 1. Tests run with bundle exec from repo root 2. Root Gemfile includes BOTH base and Pro gems (via gemspecs) 3. Dummy app package.json only has base package (intentionally) 4. Version checker correctly detected this mismatch The dummy app is specifically for testing the BASE gem/package, not Pro. In a monorepo development/testing context, it's expected that Pro gem may be available in the parent bundle even when testing the base gem. Solution: Add REACT_ON_RAILS_SKIP_VALIDATION=true to dummy test tasks, matching the existing pattern used for example app tests (line 85). This fix resolves the CI failure in: https://github.com/shakacode/react_on_rails/actions/runs/19616420258/job/56169682395?pr=2108 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent e329076 commit eed0dfa

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

rakelib/run_rspec.rake

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,14 @@ namespace :run_rspec do
6060

6161
desc "Runs dummy rspec with turbolinks"
6262
task dummy: ["dummy_apps:dummy_app"] do
63+
# Build env vars array for robustness with complex environment variables
64+
env_vars_array = []
65+
env_vars_array << rbs_runtime_env_vars unless rbs_runtime_env_vars.empty?
66+
# Skip validation since dummy app only has base gem/package but Pro may be available in parent bundle
67+
env_vars_array << "REACT_ON_RAILS_SKIP_VALIDATION=true"
68+
env_vars = env_vars_array.join(" ")
6369
run_tests_in(spec_dummy_dir,
64-
env_vars: rbs_runtime_env_vars)
70+
env_vars: env_vars)
6571
end
6672

6773
desc "Runs dummy rspec without turbolinks"
@@ -70,6 +76,8 @@ namespace :run_rspec do
7076
env_vars_array = []
7177
env_vars_array << rbs_runtime_env_vars unless rbs_runtime_env_vars.empty?
7278
env_vars_array << "DISABLE_TURBOLINKS=TRUE"
79+
# Skip validation since dummy app only has base gem/package but Pro may be available in parent bundle
80+
env_vars_array << "REACT_ON_RAILS_SKIP_VALIDATION=true"
7381
env_vars = env_vars_array.join(" ")
7482
run_tests_in(spec_dummy_dir,
7583
env_vars: env_vars,

0 commit comments

Comments
 (0)