Skip to content

Commit efa00c4

Browse files
justin808claude
andcommitted
Add CI infrastructure files pattern to ci-changes-detector
Root Cause: The ci-changes-detector script classified changes to itself and other CI infrastructure files (script/, bin/, .github/workflows/, etc.) as docs-only changes. This created a meta-problem where: 1. PR #2077 merged, changing only script/ci-changes-detector 2. Detector classified this as docs-only (ironically!) 3. ensure-master-docs-safety action ran and found previous commit had failures 4. CI correctly failed to prevent false-positive "passing" status The previous commit (3eb3961 "convert testUtils to ts") had test failures, so the safety mechanism was working correctly. But the root cause was that changes to CI infrastructure weren't triggering CI validation. Changes: - Add pattern for script/*, bin/*, .github/workflows/*, .github/actions/* - CI infrastructure changes now trigger ALL test suites - Ensures changes to CI scripts are validated before merge - Prevents meta-problem where detector changes bypass detection Impact: - Changes to CI infrastructure will trigger full test suite - Validates that CI script changes work correctly - Prevents silent breakage of CI infrastructure - Completes the fix from PR #2077 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent be024c0 commit efa00c4

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

script/ci-changes-detector

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,19 @@ while IFS= read -r file; do
138138
DOCS_ONLY=false
139139
PRO_LINT_CONFIG_CHANGED=true
140140
;;
141+
142+
# CI infrastructure files (scripts, workflows, CI configs)
143+
# Changes to CI infrastructure should trigger tests to validate the changes work
144+
script/*|script/**/*|bin/*|bin/**/*|.github/workflows/*|.github/actions/*|.github/actions/**/*|lefthook.yml)
145+
DOCS_ONLY=false
146+
RUBY_CHANGED=true # Trigger all tests for CI infrastructure changes
147+
JS_CHANGED=true
148+
SPEC_DUMMY_CHANGED=true
149+
GENERATORS_CHANGED=true
150+
PRO_RUBY_CHANGED=true
151+
PRO_JS_CHANGED=true
152+
PRO_DUMMY_CHANGED=true
153+
;;
141154
esac
142155
done <<< "$CHANGED_FILES"
143156

0 commit comments

Comments
 (0)