Skip to content

Commit f55e56c

Browse files
committed
Address PR review comments
- Add require 'net/protocol' to selenium_logger.rb for Net::ReadTimeout constant - Fix 'Java Script' typo to 'JavaScript' in error message - Remove CSS module imports and files from HelloWorld components - Revert CSS module changes as requested in review
1 parent f828595 commit f55e56c

File tree

5 files changed

+3
-14
lines changed

5 files changed

+3
-14
lines changed

lib/generators/react_on_rails/templates/base/base/app/javascript/bundles/HelloWorld/components/HelloWorld.css

Lines changed: 0 additions & 4 deletions
This file was deleted.

lib/generators/react_on_rails/templates/base/base/app/javascript/bundles/HelloWorld/components/HelloWorld.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import PropTypes from 'prop-types';
22
import React, { useState } from 'react';
3-
import './HelloWorld.css';
43

54
const HelloWorld = (props) => {
65
const [name, setName] = useState(props.name);

lib/generators/react_on_rails/templates/base/base/app/javascript/src/HelloWorld/HelloWorld.css

Lines changed: 0 additions & 4 deletions
This file was deleted.

lib/generators/react_on_rails/templates/redux/base/app/javascript/bundles/HelloWorld/components/HelloWorld.css

Lines changed: 0 additions & 4 deletions
This file was deleted.

spec/dummy/spec/support/selenium_logger.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# frozen_string_literal: true
22

3+
require "net/protocol"
4+
35
RSpec.configure do |config|
46
config.after(:each, :js) do |example|
57
next unless %i[selenium_chrome selenium_chrome_headless].include?(Capybara.current_driver)
@@ -37,6 +39,6 @@
3739
err_msg.include?("This version of ChromeDriver has not been tested with Chrome version")
3840
end
3941

40-
raise("Java Script Error(s) on the page:\n\n#{clean_errors.join("\n")}") if clean_errors.present?
42+
raise("JavaScript error(s) on the page:\n\n#{clean_errors.join("\n")}") if clean_errors.present?
4143
end
4244
end

0 commit comments

Comments
 (0)