Commit f55e56c
committed
Address PR review comments
- Add require 'net/protocol' to selenium_logger.rb for Net::ReadTimeout constant
- Fix 'Java Script' typo to 'JavaScript' in error message
- Remove CSS module imports and files from HelloWorld components
- Revert CSS module changes as requested in review1 parent f828595 commit f55e56c
File tree
5 files changed
+3
-14
lines changed- lib/generators/react_on_rails/templates
- base/base/app/javascript
- bundles/HelloWorld/components
- src/HelloWorld
- redux/base/app/javascript/bundles/HelloWorld/components
- spec/dummy/spec/support
5 files changed
+3
-14
lines changedLines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| |||
Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 0 additions & 4 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
40 | | - | |
| 42 | + | |
41 | 43 | | |
42 | 44 | | |
0 commit comments