linting

Author: AbanoubGhadban

lib/react_on_rails/configuration.rb

@@ -173,7 +173,7 @@ def validate_generated_component_packs_loading_strategy
         raise ReactOnRails::Error, msg
       end
 
-      return if [:async, :defer, :sync].include?(generated_component_packs_loading_strategy)
+      return if %i[async defer sync].include?(generated_component_packs_loading_strategy)
 
       raise ReactOnRails::Error, "generated_component_packs_loading_strategy must be either :async, :defer, or :sync"
     end

lib/react_on_rails/helper.rb

@@ -427,9 +427,7 @@ def load_pack_for_generated_component(react_component_name, render_options)
       # Old versions of Shakapacker don't support async script tags.
       # ReactOnRails.configure already validates if async loading is supported by the installed Shakapacker version.
       # Therefore, we only need to pass the async option if the loading strategy is explicitly set to :async
-      if ReactOnRails.configuration.generated_component_packs_loading_strategy == :async
-        options[:async] = true
-      end
+      options[:async] = true if ReactOnRails.configuration.generated_component_packs_loading_strategy == :async
       append_javascript_pack_tag("generated/#{react_component_name}", **options)
       append_stylesheet_pack_tag("generated/#{react_component_name}")
     end

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb

@@ -63,15 +63,19 @@ class PlainReactOnRailsHelper
         original_append_javascript_pack_tag = helper.method(:append_javascript_pack_tag)
         begin
           # Temporarily redefine append_javascript_pack_tag to handle the async keyword argument.
-          # This is needed because older versions of Shakapacker (which may be used during testing) don't support async loading,
-          # but we still want to test that the async option is passed correctly when enabled.
+          # This is needed because older versions of Shakapacker (which may be used during testing)
+          # don't support async loading, but we still want to test that the async option is passed
+          # correctly when enabled.
           def helper.append_javascript_pack_tag(name, **options)
             original_append_javascript_pack_tag.call(name, **options)
           end
           allow(helper).to receive(:append_javascript_pack_tag)
           allow(helper).to receive(:append_stylesheet_pack_tag)
           expect { helper.load_pack_for_generated_component("component_name", render_options) }.not_to raise_error
-          expect(helper).to have_received(:append_javascript_pack_tag).with("generated/component_name", { defer: false, async: true })
+          expect(helper).to have_received(:append_javascript_pack_tag).with(
+            "generated/component_name",
+            { defer: false, async: true }
+          )
           expect(helper).to have_received(:append_stylesheet_pack_tag).with("generated/component_name")
         ensure
           helper.define_singleton_method(:append_javascript_pack_tag, original_append_javascript_pack_tag)