Move shared precompile hook to spec/support and simplify generator template

Address feedback to properly organize the precompile hook code:

1. Move shared implementation to spec/support/ (test-only location)
   - Renamed: lib/tasks/precompile/shakapacker_precompile_hook_shared.rb
   - To: spec/support/shakapacker_precompile_hook_shared.rb
   - This makes it clear the shared code is only for test dummy apps

2. Simplify generator template to be standalone
   - Remove logic to load shared implementation from gem
   - Generator template is for newly created production apps
   - Should be simple, self-contained, and production-ready
   - No references to development/testing concerns

3. Update test dummy apps to reference new location
   - spec/dummy/bin/shakapacker-precompile-hook
   - react_on_rails_pro/spec/dummy/bin/shakapacker-precompile-hook
   - Both now load from spec/support/

The generator template is now clean and focused on production use cases,
while test dummy apps share common implementation from the test support directory.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

lib/generators/react_on_rails/templates/base/base/bin/shakapacker-precompile-hook

@@ -11,22 +11,6 @@
 #
 # See: https://github.com/shakacode/shakapacker/blob/main/docs/precompile_hook.md
 
-# Try to use shared implementation from gem if available (during development/testing)
-# This allows the gem's test apps and generated apps to share the same implementation
-begin
-  require "react_on_rails"
-  gem_root = Gem.loaded_specs["react_on_rails"]&.gem_dir
-  shared_hook = File.join(gem_root, "lib", "tasks", "precompile", "shakapacker_precompile_hook_shared.rb") if gem_root
-
-  if shared_hook && File.exist?(shared_hook)
-    load shared_hook
-    exit 0
-  end
-rescue LoadError, StandardError
-  # If we can't load from gem, fall through to inline implementation
-end
-
-# Inline implementation for generated apps (when gem source isn't available)
 require "fileutils"
 
 # Find Rails root by walking upward looking for config/environment.rb

react_on_rails_pro/spec/dummy/bin/shakapacker-precompile-hook

@@ -3,12 +3,12 @@
 
 # Shakapacker precompile hook for React on Rails Pro test dummy app
 #
-# This script loads the shared precompile hook implementation to avoid duplication.
-# The shared implementation is maintained in lib/tasks/precompile/shakapacker_precompile_hook_shared.rb
+# This script loads the shared test helper implementation.
+# For production apps, use the generator template which includes a standalone implementation.
 
 # Find the gem root directory (four levels up from react_on_rails_pro/spec/dummy/bin)
 gem_root = File.expand_path("../../../..", __dir__)
-shared_hook = File.join(gem_root, "lib", "tasks", "precompile", "shakapacker_precompile_hook_shared.rb")
+shared_hook = File.join(gem_root, "spec", "support", "shakapacker_precompile_hook_shared.rb")
 
 unless File.exist?(shared_hook)
   warn "❌ Error: Shared precompile hook not found at #{shared_hook}"

spec/dummy/bin/shakapacker-precompile-hook

@@ -3,12 +3,12 @@
 
 # Shakapacker precompile hook for React on Rails test dummy app
 #
-# This script loads the shared precompile hook implementation to avoid duplication.
-# The shared implementation is maintained in lib/tasks/precompile/shakapacker_precompile_hook_shared.rb
+# This script loads the shared test helper implementation.
+# For production apps, use the generator template which includes a standalone implementation.
 
 # Find the gem root directory (three levels up from spec/dummy/bin)
 gem_root = File.expand_path("../../..", __dir__)
-shared_hook = File.join(gem_root, "lib", "tasks", "precompile", "shakapacker_precompile_hook_shared.rb")
+shared_hook = File.join(gem_root, "spec", "support", "shakapacker_precompile_hook_shared.rb")
 
 unless File.exist?(shared_hook)
   warn "❌ Error: Shared precompile hook not found at #{shared_hook}"