-
-
Notifications
You must be signed in to change notification settings - Fork 638
Closed
Labels
Description
Summary
Add RBS type signatures for error-related classes to complete type coverage.
Missing Classes
Currently these classes lack RBS signatures:
ReactOnRails::ErrorReactOnRails::JsonParseErrorReactOnRails::PrerenderErrorReactOnRails::SmartError
Implementation Files
lib/react_on_rails/error.rblib/react_on_rails/json_parse_error.rblib/react_on_rails/prerender_error.rblib/react_on_rails/smart_error.rb
Proposed Signatures
# sig/react_on_rails/error.rbs
module ReactOnRails
class Error < StandardError
end
end
# sig/react_on_rails/prerender_error.rbs
module ReactOnRails
class PrerenderError < Error
def initialize: (
component_name: String,
props: String?,
err: StandardError?,
js_code: String?,
?console_messages: String?
) -> void
attr_reader component_name: String
attr_reader props: String?
attr_reader err: StandardError?
attr_reader js_code: String?
end
endScope
This was intentionally excluded from PR #1945 to focus on public API coverage. This issue tracks adding these internal/error types.
Priority
Low - Error classes are used internally and type coverage for public API is complete.
Related
Follow-up to PR #1945