-
-
Notifications
You must be signed in to change notification settings - Fork 633
Open
Description
Summary
The release script introduced in PR #1856 creates git tags with a v prefix (e.g., v16.2.0.beta.1), but all historical tags from version 2.0.0 through 16.1.2 do NOT have the v prefix (e.g., 16.1.1).
This inconsistency caused a broken CHANGELOG link (fixed in PR #2263) where Claude assumed 16.1.1 should be v16.1.1 to match the new tag pattern.
Details
Old release process (16.1.1 and earlier):
- Used
release-itnpm tool release-itauto-detected tag format from existing tags- Created tags WITHOUT 'v' prefix:
16.0.0,16.1.0,16.1.1
New release process (16.2.0.beta.0 onwards):
- PR Modernize release process for monorepo #1856 replaced
release-itwith manual git commands - Explicitly adds 'v' prefix:
git tag v#{actual_gem_version} - Creates tags WITH 'v' prefix:
v16.2.0.beta.0,v16.2.0.rc.0
Tag inventory
WITHOUT 'v' prefix (versions 2.0.0 - 16.1.2):
2.0.0, 3.0.0, 4.0.0, ..., 16.0.0, 16.1.0, 16.1.1, 16.1.2
WITH 'v' prefix (versions 16.2.0+):
v16.2.0.beta.0, v16.2.0.beta.1, ..., v16.2.0.rc.0
Note: Very early versions (0.x, 1.x) had mixed conventions with some 'v' prefixed tags.
Recommendation
Pick one convention and stick to it:
Option A: Remove 'v' prefix (match historical convention)
- Change
rakelib/release.rakeline 254 fromgit tag v#{actual_gem_version}togit tag #{actual_gem_version} - More consistent with 9+ years of existing tags (2.0.0 through 16.1.2)
Option B: Keep 'v' prefix (new convention)
- Document this as the new convention going forward
- Accept that CHANGELOG links crossing the 16.1.x → 16.2.x boundary will need mixed formats
References
- PR Modernize release process for monorepo #1856 introduced the 'v' prefix (replaced release-it with manual git commands)
- PR Fix release script after pnpm monorepo restructure #2173 carried forward the 'v' prefix during monorepo restructure
- PR Fix version link formatting in CHANGELOG.md #2263 fixed the broken CHANGELOG link caused by this inconsistency
Metadata
Metadata
Assignees
Labels
No labels