Fix bundle path resolution and improve server bundle security#1798

Merged

justin808 merged 31 commits intomasterfrom

feature/improve-bundle-path-resolution

Sep 24, 2025

Commits on Sep 23, 2025

Fix server bundle path resolution in test environments (#1797)

authored and
AbanoubGhadban
committed
Improve bundle path resolution with secure server bundle locations

authored and
AbanoubGhadban
committed
Apply suggestions from code review

authored and
AbanoubGhadban
committed
Update Gemfile.lock and CHANGELOG.md

justin808
authored and
AbanoubGhadban
committed
Add configuration options for secure server bundle management

authored and
AbanoubGhadban
committed
Fix breaking change: Set server_bundle_output_path default to nil

authored and
AbanoubGhadban
committed
Fix CI failures by restoring packer availability check

authored and
AbanoubGhadban
committed
Clean solution: Remove redundant using_packer? check with proper test handling

authored and
AbanoubGhadban
committed
Implement enforce_secure_server_bundles with comprehensive improvements

authored and
AbanoubGhadban
committed
refactor: Use configuration-based approach for server bundle output path

github-actions[bot]
and
AbanoubGhadban
committed
refactor: Use configuration-based approach for server bundle output path

github-actions[bot]
and
AbanoubGhadban
committed
Fix CI failures: RuboCop violations and test failures

github-actions[bot]
and
AbanoubGhadban
committed
Fix dummy app configuration for test environment

github-actions[bot]
and
AbanoubGhadban
committed
refactor: Return configured server_bundle_output_path directly without existence check

github-actions[bot]
and
AbanoubGhadban
committed
Fix CI failures: RuboCop violations and test failures

github-actions[bot]
and
AbanoubGhadban
committed
refactor: Rename 'secure' to 'private' for server bundles terminology

authored and
AbanoubGhadban
committed
fix: Remove obsolete using_packer? method references

github-actions[bot]
and
claude
committed
update changelog.md
AbanoubGhadban
committed
Clarify method naming: rename generated_assets_full_path → public_assets_full_path

authored and
AbanoubGhadban
committed
Improve method naming: use public_bundles_full_path instead of public_assets_full_path

authored and
AbanoubGhadban
committed
Refactor: Update test mocks to use public_bundles_full_path
AbanoubGhadban
committed
Enhance configuration documentation and clarify directory structure for server and client bundles
AbanoubGhadban
committed
Update changelog and configuration to reflect breaking changes and enhancements
AbanoubGhadban
committed
Don't fall back to public directory if enforce_private_server_bundles is enabled
AbanoubGhadban
committed
Enhance server bundle path resolution logic
AbanoubGhadban
committed
Update server bundle path resolution to utilize public output path
AbanoubGhadban
committed
Fix remaining test failures: update all packer method references

justin808
and
claude
committed
Fix CI test failures: update test mocks for enforce_private_server_bundles

justin808
and
claude
committed
Correct test expectations for new fallback behavior

justin808
and
claude
committed
Add TODO for shakapacker.yml integration enhancement

justin808
and
claude
committed
Change validation error to warning for deprecated generated_assets_dirs

justin808
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix bundle path resolution and improve server bundle security#1798

Fix bundle path resolution and improve server bundle security#1798
justin808 merged 31 commits intomasterfrom
feature/improve-bundle-path-resolution

Commits on Sep 23, 2025

Fix server bundle path resolution in test environments (#1797)

Improve bundle path resolution with secure server bundle locations

Apply suggestions from code review

Update Gemfile.lock and CHANGELOG.md

Add configuration options for secure server bundle management

Fix breaking change: Set server_bundle_output_path default to nil

Fix CI failures by restoring packer availability check

Clean solution: Remove redundant using_packer? check with proper test handling

Implement enforce_secure_server_bundles with comprehensive improvements

refactor: Use configuration-based approach for server bundle output path

refactor: Use configuration-based approach for server bundle output path

Fix CI failures: RuboCop violations and test failures

Fix dummy app configuration for test environment

refactor: Return configured server_bundle_output_path directly without existence check

Fix CI failures: RuboCop violations and test failures

refactor: Rename 'secure' to 'private' for server bundles terminology

fix: Remove obsolete using_packer? method references

update changelog.md

Clarify method naming: rename generated_assets_full_path → public_assets_full_path

Improve method naming: use public_bundles_full_path instead of public_assets_full_path

Refactor: Update test mocks to use public_bundles_full_path

Enhance configuration documentation and clarify directory structure for server and client bundles

Update changelog and configuration to reflect breaking changes and enhancements

Don't fall back to public directory if enforce_private_server_bundles is enabled

Enhance server bundle path resolution logic

Update server bundle path resolution to utilize public output path

Fix remaining test failures: update all packer method references

Fix CI test failures: update test mocks for enforce_private_server_bundles

Correct test expectations for new fallback behavior

Add TODO for shakapacker.yml integration enhancement

Change validation error to warning for deprecated generated_assets_dirs

Uh oh!

Fix bundle path resolution and improve server bundle security#1798justin808 merged 31 commits intomastershakacode/react_on_rails:masterfrom feature/improve-bundle-path-resolutionshakacode/react_on_rails:feature/improve-bundle-path-resolutionCopy head branch name to clipboard

Commits

Commits on Sep 23, 2025

Fix bundle path resolution and improve server bundle security#1798
justin808 merged 31 commits intomasterfrom
feature/improve-bundle-path-resolution