Skip to content

Fix bug at resolving react-server-client-manifest.json file #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2025
Merged

Fix bug at resolving react-server-client-manifest.json file #1818

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b7c076
Enhance server bundle handling by adding support for react_server_cli…
AbanoubGhadban Sep 24, 2025
81c385f
Fix failing tests after react_server_client_manifest_file changes
github-actions[bot] Sep 24, 2025
19e3650
Revert "Fix failing tests after react_server_client_manifest_file cha…
AbanoubGhadban Sep 24, 2025
2f267d8
Enhance tests for react_server_client_manifest_file_path
AbanoubGhadban Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/react_on_rails/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ def self.bundle_js_file_path(bundle_name)
private_class_method def self.server_bundle?(bundle_name)
config = ReactOnRails.configuration
bundle_name == config.server_bundle_js_file ||
bundle_name == config.rsc_bundle_js_file
bundle_name == config.rsc_bundle_js_file ||
bundle_name == config.react_server_client_manifest_file
end

private_class_method def self.handle_missing_manifest_entry(bundle_name, is_server_bundle)
Expand Down Expand Up @@ -170,7 +171,7 @@ def self.react_server_client_manifest_file_path
"react_server_client_manifest_file is nil, ensure it is set in your configuration"
end

@react_server_manifest_path = File.join(public_bundles_full_path, asset_name)
@react_server_manifest_path = bundle_js_file_path(asset_name)
end

def self.running_on_windows?
Expand Down
Loading