Catch errors in notifiers

Author: alexeyr

packages/node-renderer/src/shared/errorReporter.ts

@@ -1,8 +1,9 @@
 import log from './log';
 import type { TracingContext } from './tracing';
 
-export type MessageNotifier = (msg: string, tracingContext?: TracingContext) => void;
-export type ErrorNotifier = (err: Error, tracingContext?: TracingContext) => void;
+export type Notifier<T> = (msg: T, tracingContext?: TracingContext) => void;
+export type MessageNotifier = Notifier<string>;
+export type ErrorNotifier = Notifier<Error>;
 
 const messageNotifiers: MessageNotifier[] = [];
 const errorNotifiers: ErrorNotifier[] = [];
@@ -24,27 +25,35 @@ export function addErrorNotifier(notifier: ErrorNotifier) {
 /**
  * Adds a callback to notify an error tracking service on both string error messages and JavaScript {@link Error}s.
  */
-export function addNotifier(notifier: (msg: string | Error) => void) {
+export function addNotifier(notifier: Notifier<string | Error>) {
   messageNotifiers.push(notifier);
   errorNotifiers.push(notifier);
 }
 
+function notify<T>(msg: T, tracingContext: TracingContext | undefined, notifiers: Notifier<T>[]) {
+  log.error(`ErrorReporter notification: ${msg}`);
+  notifiers.forEach((notifier) => {
+    try {
+      notifier(msg, tracingContext);
+    } catch (e) {
+      log.error(
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+        `An error tracking notifier failed: ${(e as Error).message ?? e}\nStack:\n${(e as Error).stack}`,
+      );
+    }
+  });
+}
+
 /**
  * Reports an error message.
  */
 export function message(msg: string, tracingContext?: TracingContext) {
-  log.error(`ErrorReporter notification: ${msg}`);
-  messageNotifiers.forEach((notifier) => {
-    notifier(msg, tracingContext);
-  });
+  notify(msg, tracingContext, messageNotifiers);
 }
 
 /**
  * Reports an error.
  */
 export function error(err: Error, tracingContext?: TracingContext) {
-  log.error(`ErrorReporter notification: ${err}`);
-  errorNotifiers.forEach((notifier) => {
-    notifier(err, tracingContext);
-  });
+  notify(err, tracingContext, errorNotifiers);
 }

packages/node-renderer/tests/shared/tracing.test.ts

@@ -2,6 +2,7 @@ import { jest } from '@jest/globals';
 
 import * as Sentry from '@sentry/node';
 import sentryTestkit from 'sentry-testkit';
+import * as errorReporter from '../../src/shared/errorReporter';
 import { trace } from '../../src/shared/tracing';
 import * as tracingIntegration from '../../src/integrations/sentry';
 
@@ -29,7 +30,7 @@ test('should run function and finish span', async () => {
   const message = 'test';
   await trace(async () => {
     savedSpan = Sentry.getActiveSpan();
-    Sentry.captureMessage(message);
+    errorReporter.message(message);
     await fn();
   }, testTransactionContext);
   expect(savedSpan).toBeDefined();